Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 868663007: Reinstated onBlur handler and added images for CWS. (Closed)

Created:
5 years, 10 months ago by Jamie
Modified:
5 years, 10 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reinstated onBlur handler and added images for CWS. The onBlur handler was accidentally removed by my recent refactoring. The images are required for submissions to CWS; only the icon needs to included in the crx, however. Committed: https://crrev.com/16accd4cbfbf5ebd9adafc67164d359ab6f54e43 Cr-Commit-Position: refs/heads/master@{#314961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M remoting/remoting_key_tester.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/tools/javascript_key_tester/event_listeners.js View 3 chunks +17 lines, -5 lines 0 comments Download
A remoting/tools/javascript_key_tester/icon_128.png View Binary file 0 comments Download
M remoting/tools/javascript_key_tester/manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download
A remoting/tools/javascript_key_tester/promo_440x280.png View Binary file 0 comments Download
A remoting/tools/javascript_key_tester/screenshot_640x400.png View Binary file 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie
ptal
5 years, 10 months ago (2015-02-05 01:38:24 UTC) #2
kelvinp
lgtm
5 years, 10 months ago (2015-02-06 01:28:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868663007/1
5 years, 10 months ago (2015-02-06 01:49:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 03:41:07 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 03:43:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16accd4cbfbf5ebd9adafc67164d359ab6f54e43
Cr-Commit-Position: refs/heads/master@{#314961}

Powered by Google App Engine
This is Rietveld 408576698