Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 868643003: Fix SkIStream nits. (Closed)

Created:
5 years, 11 months ago by bungeman-skia
Modified:
5 years, 11 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SkIStream nits. Fix comment, constness of one field, and delete already checks for NULL. TBR=reed@google.com Trivial change to debatably public api. Committed: https://skia.googlesource.com/skia/+/44af7ba4bc571110f02f31dd71a8fd4dc7e6bfd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M include/utils/win/SkIStream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/win/SkIStream.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
bungeman-skia
5 years, 11 months ago (2015-01-22 14:28:26 UTC) #2
scroggo
lgtm
5 years, 11 months ago (2015-01-22 14:29:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868643003/1
5 years, 11 months ago (2015-01-22 14:29:27 UTC) #5
commit-bot: I haz the power
Presubmit check for 868643003-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 11 months ago (2015-01-22 14:29:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868643003/1
5 years, 11 months ago (2015-01-22 15:26:37 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 15:33:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/44af7ba4bc571110f02f31dd71a8fd4dc7e6bfd2

Powered by Google App Engine
This is Rietveld 408576698