Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 868613004: Use auto-generated v8 version when building. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use auto-generated v8 version when building. BUG=chromium:446166 LOG=n

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-22 13:25:45 UTC) #2
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-22 13:25:45 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-22 13:27:20 UTC) #4
Michael Achenbach
5 years, 11 months ago (2015-01-23 09:50:35 UTC) #5
I'm going to bury this due to a bunch of problems:
https://code.google.com/p/chromium/issues/detail?id=451137

Powered by Google App Engine
This is Rietveld 408576698