Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 868613002: a typo in SkResourceCacheTest (Closed)

Created:
5 years, 11 months ago by yunchao
Modified:
5 years, 11 months ago
Reviewers:
humper, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

a typo in SkResourceCacheTest BUG=skia: Committed: https://skia.googlesource.com/skia/+/90acb8e97cb123adc25d030b6dbe868d32856f47

Patch Set 1 #

Patch Set 2 : to expose the error of previous code + more typos in this file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M tests/SkResourceCacheTest.cpp View 1 2 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yunchao
5 years, 11 months ago (2015-01-22 07:46:51 UTC) #2
reed1
good catch. perhaps we should also modify test_scaled_image_cache_useage() to pass different x and y scale ...
5 years, 11 months ago (2015-01-22 15:53:03 UTC) #3
yunchao
On 2015/01/22 15:53:03, reed1 wrote: > good catch. > > perhaps we should also modify ...
5 years, 11 months ago (2015-01-23 07:00:06 UTC) #4
reed1
lgtm
5 years, 11 months ago (2015-01-23 14:03:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868613002/20001
5 years, 11 months ago (2015-01-24 00:58:57 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 01:06:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/90acb8e97cb123adc25d030b6dbe868d32856f47

Powered by Google App Engine
This is Rietveld 408576698