Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 868603007: Mechanical rename of base::debug -> base::trace_event [final pass]. (Closed)

Created:
5 years, 11 months ago by ssid
Modified:
5 years, 10 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_trace_part3_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mechanical rename of base::debug -> base::trace_event [final pass] This is the last stage of the trace_event directory restructuring. This is part of a set of 3 CLs which is moving tracing clients to use the new base::trace_debug namespace. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=jam@chromium.org Committed: https://crrev.com/759dd8c5b9b2ece67ac0dc8e406436eff5b69d4f Cr-Commit-Position: refs/heads/master@{#315397}

Patch Set 1 #

Patch Set 2 : Moved /content changes to different CL. #

Patch Set 3 : Removing build/sanitizers/tsan_suppressions.cc #

Total comments: 1

Patch Set 4 : Removed namespace aliasing. #

Patch Set 5 : Fixing win file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -164 lines) Patch
M android_webview/browser/browser_view_renderer.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/android/trace_event_binding.cc View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download
M base/files/file_path_watcher_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_pending_task.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/test_pending_task.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M base/test/trace_event_analyzer.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M base/test/trace_event_analyzer_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M base/test/trace_to_file.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M base/trace_event/trace_event.h View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M base/trace_event/trace_event_argument.h View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M base/trace_event/trace_event_impl.h View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
M base/trace_event/trace_event_win.h View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/base/tracing.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/logging/win/file_logger.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/logging/win/log_file_reader.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M components/feedback/tracing_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/tracing/child_trace_message_filter.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M components/tracing/tracing_messages.h View 1 4 chunks +6 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gpu_state_tracer.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_message.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M net/base/trace_net_log_observer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/trace_net_log_observer.cc View 1 3 chunks +15 lines, -15 lines 0 comments Download
M net/base/trace_net_log_observer_unittest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ppapi/shared_impl/ppb_trace_event_impl.cc View 1 3 chunks +13 lines, -12 lines 0 comments Download
M skia/ext/event_tracer_impl.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M ui/compositor/layer.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ui/compositor/layer.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/latency_info.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (5 generated)
ssid
5 years, 11 months ago (2015-01-27 17:59:45 UTC) #2
ssid
Should I split this into small CLs, like what you did for the includes?
5 years, 10 months ago (2015-02-03 07:41:00 UTC) #3
Primiano Tucci (use gerrit)
On 2015/02/03 07:41:00, ssid wrote: > Should I split this into small CLs, like what ...
5 years, 10 months ago (2015-02-03 10:50:50 UTC) #4
Primiano Tucci (use gerrit)
On 2015/02/03 10:50:50, Primiano Tucci wrote: > On 2015/02/03 07:41:00, ssid wrote: > > Should ...
5 years, 10 months ago (2015-02-03 11:17:07 UTC) #5
ssid
Split the CL. PTAL.
5 years, 10 months ago (2015-02-03 15:55:39 UTC) #6
Primiano Tucci (use gerrit)
On 2015/02/03 15:55:39, ssid wrote: > Split the CL. PTAL. There are 3 namespaces leftover ...
5 years, 10 months ago (2015-02-09 12:07:05 UTC) #7
Primiano Tucci (use gerrit)
On 2015/02/09 12:07:05, Primiano Tucci wrote: > On 2015/02/03 15:55:39, ssid wrote: > > Split ...
5 years, 10 months ago (2015-02-09 12:17:37 UTC) #8
Primiano Tucci (use gerrit)
https://codereview.chromium.org/868603007/diff/40001/base/test/trace_event_analyzer.h File base/test/trace_event_analyzer.h (left): https://codereview.chromium.org/868603007/diff/40001/base/test/trace_event_analyzer.h#oldcode75 base/test/trace_event_analyzer.h:75: Nit: You accidentally ate this line.
5 years, 10 months ago (2015-02-09 12:17:45 UTC) #9
ssid
On 2015/02/09 12:17:45, Primiano Tucci wrote: > https://codereview.chromium.org/868603007/diff/40001/base/test/trace_event_analyzer.h > File base/test/trace_event_analyzer.h (left): > > https://codereview.chromium.org/868603007/diff/40001/base/test/trace_event_analyzer.h#oldcode75 ...
5 years, 10 months ago (2015-02-09 13:25:36 UTC) #10
Primiano Tucci (use gerrit)
PS4 (#60001) LGTM. I think with this one we are finally done! TBR-ing jam@ for ...
5 years, 10 months ago (2015-02-09 18:38:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868603007/60001
5 years, 10 months ago (2015-02-09 18:39:39 UTC) #14
Primiano Tucci (use gerrit)
PS5 LGTM
5 years, 10 months ago (2015-02-09 20:31:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868603007/80001
5 years, 10 months ago (2015-02-09 20:34:07 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-09 21:26:02 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 21:26:52 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/759dd8c5b9b2ece67ac0dc8e406436eff5b69d4f
Cr-Commit-Position: refs/heads/master@{#315397}

Powered by Google App Engine
This is Rietveld 408576698