Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 868603003: [svg2] Drop suspendRedraw, unsuspendRedraw[All] and forceRedraw. (Closed)

Created:
5 years, 11 months ago by Erik Dahlström (inactive)
Modified:
5 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, krit, arv+blink, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Inactive, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[svg2] Drop suspendRedraw, unsuspendRedraw[All] and forceRedraw. These methods are all no-ops. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/svg/SVGSVGElement.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Erik Dahlström (inactive)
Promised I'd try dropping these old deprecated methods, https://lists.w3.org/Archives/Public/public-svg-wg/2014JanMar/att-0096/minutes_13_02_14.html#item06. Potentially this may break some old ...
5 years, 11 months ago (2015-01-22 09:59:47 UTC) #2
pdr.
5 years, 10 months ago (2015-01-30 22:11:18 UTC) #3
On 2015/01/22 at 09:59:47, ed wrote:
> Promised I'd try dropping these old deprecated methods,
https://lists.w3.org/Archives/Public/public-svg-wg/2014JanMar/att-0096/minute....
> 
> Potentially this may break some old content (I'm not that worried about it,
should be a very minor fraction of content). These methods have been stubs for
quite some time.
> 
> Let me know think I should still send out an intent-to-remove (I don't expect
this to be a controversial change).

I apologize for the slow reviews this week.

I think this looks great, LGTM.

Because this touches global-interface-listing, I think we should shoot a quick
intent about it though--could you do that? Phistuck will call us out if we don't
:)

Powered by Google App Engine
This is Rietveld 408576698