Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2071)

Issue 868583002: Revert of Steps towards unification of number bitset and range types. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Steps towards unification of number bitset and range types. (patchset #4 id:60001 of https://codereview.chromium.org/837723006/) Reason for revert: Breaks test-types/Maybe, i.e. out/Release/cctest --random-seed=-707413401 test-types/Maybe started failing afterwards Original issue's description: > Steps towards unification of number bitset and range types. > > - New invariant on union types: if the union has a range then the number > bits in the bitset must be cleared. > > - Various tweaks in intersection and union to satisfy the invariant. > > - Exposed and used representation bits in range types (and the Limits > helper class). > > - Implemented Glb for ranges so that the Is predicate handles > ranges correctly. > > - Change typer weakening so that it does not rely on GetRange. > However, the code still seems to be a bit fragile. > > - Removed the Smi types from the type system core, instead introduced > Signed31, Unsigned30 and created constructors for Small(Un)Signed > that point to the right type for the architecture. > > - Punched a hole in the config to be able to get to the isolate so > that it is possible to allocate heap numbers for newly created > ranges. > > Patch by jarin@chromium.prg, original review here: > https://codereview.chromium.org/795713003/ > > TBR=jarin@chromium.org > BUG= > > Committed: https://crrev.com/2764fd8d1a266a9136c987c2483492113b0c8d80 > Cr-Commit-Position: refs/heads/master@{#26197} TBR=jkummerow@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/76193749791eac9032f47db2f04efd78c0e120a9 Cr-Commit-Position: refs/heads/master@{#26207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -534 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/typer.cc View 2 chunks +35 lines, -46 lines 0 comments Download
M src/types.h View 15 chunks +62 lines, -82 lines 0 comments Download
M src/types.cc View 19 chunks +104 lines, -327 lines 0 comments Download
M src/types-inl.h View 3 chunks +0 lines, -19 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +18 lines, -14 lines 0 comments Download
M test/cctest/test-types.cc View 7 chunks +36 lines, -35 lines 0 comments Download
M test/cctest/types-fuzz.h View 2 chunks +0 lines, -5 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
Created Revert of Steps towards unification of number bitset and range types.
5 years, 11 months ago (2015-01-22 05:32:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868583002/1
5 years, 11 months ago (2015-01-22 05:33:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 05:33:30 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76193749791eac9032f47db2f04efd78c0e120a9 Cr-Commit-Position: refs/heads/master@{#26207}
5 years, 11 months ago (2015-01-22 05:33:53 UTC) #4
Jakob Kummerow
5 years, 11 months ago (2015-01-22 08:17:24 UTC) #5
Message was sent while issue was closed.
rubberstamp LGTM

Powered by Google App Engine
This is Rietveld 408576698