Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issue 868573003: GN: Change webrtc_base -> rtc_base (Closed)

Created:
5 years, 11 months ago by kjellander_chromium
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Change webrtc_base -> rtc_base The target was renamed in GYP a while back and in https://code.google.com/p/webrtc/source/detail?r=8117 for GN. This is the last reference left using the 'webrtc_base' target name. TBR=tommi@chromium.org Committed: https://crrev.com/7c9149860a8a0ca24350d2e80dbc280990a0cbb7 Cr-Commit-Position: refs/heads/master@{#313100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/libjingle/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
kjellander_chromium
5 years, 11 months ago (2015-01-26 19:14:27 UTC) #3
hellner1
lgtm
5 years, 11 months ago (2015-01-26 19:17:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868573003/1
5 years, 11 months ago (2015-01-26 19:21:53 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-26 19:21:54 UTC) #8
kjellander_chromium
TBR'ing tommi
5 years, 11 months ago (2015-01-26 19:24:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868573003/1
5 years, 11 months ago (2015-01-26 19:26:00 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 19:30:15 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 19:31:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c9149860a8a0ca24350d2e80dbc280990a0cbb7
Cr-Commit-Position: refs/heads/master@{#313100}

Powered by Google App Engine
This is Rietveld 408576698