Move OpenProcessHandle to Process::Open.

chrome/test/base/chrome_process_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/chrome_process_util.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/process/kill.h"
+#include "base/process/process.h"
 #include "base/process/process_iterator.h"
 #include "base/time/time.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/test/base/test_switches.h"
 #include "content/public/common/result_codes.h"
 
 using base::TimeDelta;
 using base::TimeTicks;
 
 namespace {
@@ skipping 19 matching lines @@
 #endif
 
   return names;
 }
 
 }  // namespace
 
 void TerminateAllChromeProcesses(const ChromeProcessList& process_pids) {
   ChromeProcessList::const_iterator it;
   for (it = process_pids.begin(); it != process_pids.end(); ++it) {
-    base::ProcessHandle handle;
-    if (!base::OpenProcessHandle(*it, &handle)) {
+    base::Process process = base::Process::Open(*it);
+    if (process.IsValid()) {
       // Ignore processes for which we can't open the handle. We don't
       // guarantee that all processes will terminate, only try to do so.
-      continue;
+      base::KillProcess(process.Handle(), content::RESULT_CODE_KILLED, true);

[sky, 2015/02/04 17:14:52]

Seems like it would be nice to do process.Kill(...) rather than an intermediary.

[rvargas (doing something else), 2015/02/04 18:19:51]

Yes, that's part of the plan (remove the utility functions that take a
ProcessHandle)

     }
-
-    base::KillProcess(handle, content::RESULT_CODE_KILLED, true);
-    base::CloseProcessHandle(handle);
   }
 }
 
 class ChildProcessFilter : public base::ProcessFilter {
  public:
   explicit ChildProcessFilter(base::ProcessId parent_pid)
       : parent_pids_(&parent_pid, (&parent_pid) + 1) {}
 
   explicit ChildProcessFilter(const std::vector<base::ProcessId>& parent_pids)
       : parent_pids_(parent_pids.begin(), parent_pids.end()) {}
@@ skipping 73 matching lines @@
     base::ProcessHandle process) {
 #if !defined(OS_MACOSX)
   process_metrics_.reset(
       base::ProcessMetrics::CreateProcessMetrics(process));
 #else
   process_metrics_.reset(
       base::ProcessMetrics::CreateProcessMetrics(process, NULL));
 #endif
   process_handle_ = process;
 }