Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: base/process/process_handle_posix.cc

Issue 868543002: Move OpenProcessHandle to Process::Open. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/process/process_handle.h" 5 #include "base/process/process_handle.h"
6 6
7 #include <unistd.h> 7 #include <unistd.h>
8 8
9 namespace base { 9 namespace base {
10 10
11 ProcessId GetCurrentProcId() { 11 ProcessId GetCurrentProcId() {
12 return getpid(); 12 return getpid();
13 } 13 }
14 14
15 ProcessHandle GetCurrentProcessHandle() { 15 ProcessHandle GetCurrentProcessHandle() {
16 return GetCurrentProcId(); 16 return GetCurrentProcId();
17 } 17 }
18 18
19 bool OpenProcessHandle(ProcessId pid, ProcessHandle* handle) {
20 // On Posix platforms, process handles are the same as PIDs, so we
21 // don't need to do anything.
22 *handle = pid;
23 return true;
cpu_(ooo_6.6-7.5) 2015/01/28 17:17:50 is zero special? as in returning false?
rvargas (doing something else) 2015/02/02 19:47:09 Zero is the value for invalid handle / pid. This s
24 }
25
26 void CloseProcessHandle(ProcessHandle process) { 19 void CloseProcessHandle(ProcessHandle process) {
27 // See OpenProcessHandle, nothing to do. 20 // See OpenProcessHandle, nothing to do.
28 return; 21 return;
29 } 22 }
30 23
31 ProcessId GetProcId(ProcessHandle process) { 24 ProcessId GetProcId(ProcessHandle process) {
32 return process; 25 return process;
33 } 26 }
34 27
35 } // namespace base 28 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698