Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 868503003: Enable RSSI proximity check by default. (Closed)

Created:
5 years, 10 months ago by Tim Song
Modified:
5 years, 10 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable RSSI proximity check by default. BUG=455311 Committed: https://crrev.com/1acfeef4d4876da66e94b2d2813123debe5bdbc0 Cr-Commit-Position: refs/heads/master@{#314958}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 chunk +0 lines, -7 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
Tim Song
5 years, 10 months ago (2015-02-05 22:09:16 UTC) #2
Ilya Sherman
https://codereview.chromium.org/868503003/diff/1/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc File chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc (left): https://codereview.chromium.org/868503003/diff/1/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc#oldcode708 chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:708: } Please remove the flag as well. Or, if ...
5 years, 10 months ago (2015-02-05 23:59:41 UTC) #3
Tim Song
https://codereview.chromium.org/868503003/diff/1/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc File chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc (left): https://codereview.chromium.org/868503003/diff/1/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc#oldcode708 chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:708: } On 2015/02/05 23:59:41, Ilya Sherman wrote: > Please ...
5 years, 10 months ago (2015-02-06 00:43:01 UTC) #4
Ilya Sherman
On 2015/02/06 00:43:01, Tim Song wrote: > https://codereview.chromium.org/868503003/diff/1/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc > File > chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc > (left): > ...
5 years, 10 months ago (2015-02-06 00:44:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868503003/1
5 years, 10 months ago (2015-02-06 02:24:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 03:38:28 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 03:39:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1acfeef4d4876da66e94b2d2813123debe5bdbc0
Cr-Commit-Position: refs/heads/master@{#314958}

Powered by Google App Engine
This is Rietveld 408576698