Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

Issue 868483006: dart2js: remove additionalProperties and store it directly as nativeBlob. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
index 88c5f612ccc7a48d7846d4cbc7267212f3873774..a70992768dc0916e762d9ffc94b9f55ace0cc5cd 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
@@ -12,9 +12,7 @@ class ClassEmitter extends CodeEmitterHelper {
/**
* Documentation wanted -- johnniwinther
*/
- void emitClass(Class cls,
- ClassBuilder enclosingBuilder,
- Map<String, jsAst.Expression> additionalProperties) {
+ void emitClass(Class cls, ClassBuilder enclosingBuilder) {
ClassElement classElement = cls.element;
assert(invariant(classElement, classElement.isDeclaration));
@@ -43,9 +41,7 @@ class ClassEmitter extends CodeEmitterHelper {
emitInstanceMembers(cls, builder);
emitCallStubs(cls, builder);
emitRuntimeTypeInformation(cls, builder);
- if (additionalProperties != null) {
- additionalProperties.forEach(builder.addProperty);
- }
+ emitNativeBlob(cls, builder);
if (classElement == backend.closureClass) {
// We add a special getter here to allow for tearing off a closure from
@@ -271,6 +267,12 @@ class ClassEmitter extends CodeEmitterHelper {
}
}
+ void emitNativeBlob(Class cls, ClassBuilder builder) {
+ if (cls.nativeBlob != null) {
+ builder.addProperty(namer.nativeSpecProperty, js.string(cls.nativeBlob));
+ }
+ }
+
void emitClassBuilderWithReflectionData(Class cls,
ClassBuilder classBuilder,
ClassBuilder enclosingBuilder) {

Powered by Google App Engine
This is Rietveld 408576698