Chromium Code Reviews

Issue 868473004: External name changes of release scripts. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

External name changes of release scripts. Moved and renamed the scripts to fit with git. These changes require documentation updates, updates of the release spreadsheet and the buildbot side. BUG=chromium:451975 TBR=tandrii@chromium.org NOTRY=true LOG=n Committed: https://crrev.com/ae22d7f8739fe838fafb2d118f9b8a316403383b Cr-Commit-Position: refs/heads/master@{#26271}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+5 lines, -4623 lines)
D tools/push-to-trunk/auto_push.py View 1 chunk +0 lines, -127 lines 0 comments
D tools/push-to-trunk/auto_roll.py View 1 chunk +0 lines, -142 lines 0 comments
D tools/push-to-trunk/auto_tag.py View 1 chunk +0 lines, -201 lines 0 comments
D tools/push-to-trunk/check_clusterfuzz.py View 1 chunk +0 lines, -174 lines 0 comments
D tools/push-to-trunk/chromium_roll.py View 1 chunk +0 lines, -155 lines 0 comments
D tools/push-to-trunk/common_includes.py View 1 chunk +0 lines, -813 lines 0 comments
D tools/push-to-trunk/git_recipes.py View 1 chunk +0 lines, -275 lines 0 comments
D tools/push-to-trunk/merge_to_branch.py View 1 chunk +0 lines, -316 lines 0 comments
D tools/push-to-trunk/push_to_trunk.py View 1 chunk +0 lines, -454 lines 0 comments
D tools/push-to-trunk/releases.py View 1 chunk +0 lines, -507 lines 0 comments
D tools/push-to-trunk/script_test.py View 1 chunk +0 lines, -54 lines 0 comments
D tools/push-to-trunk/test_scripts.py View 1 chunk +0 lines, -1400 lines 0 comments
A + tools/release/auto_push.py View 2 chunks +2 lines, -2 lines 0 comments
A + tools/release/auto_roll.py View 0 chunks +-1 lines, --1 lines 0 comments
A + tools/release/auto_tag.py View 0 chunks +-1 lines, --1 lines 0 comments
A + tools/release/check_clusterfuzz.py View 0 chunks +-1 lines, --1 lines 0 comments
A + tools/release/chromium_roll.py View 0 chunks +-1 lines, --1 lines 0 comments
A + tools/release/common_includes.py View 0 chunks +-1 lines, --1 lines 0 comments
A + tools/release/git_recipes.py View 0 chunks +-1 lines, --1 lines 0 comments
A + tools/release/merge_to_branch.py View 0 chunks +-1 lines, --1 lines 0 comments
A + tools/release/push_to_candidates.py View 0 chunks +-1 lines, --1 lines 0 comments
A + tools/release/releases.py View 1 chunk +2 lines, -2 lines 2 comments
A + tools/release/script_test.py View 0 chunks +-1 lines, --1 lines 0 comments
A + tools/release/test_scripts.py View 6 chunks +10 lines, -10 lines 0 comments

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-26 14:11:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868473004/1
5 years, 11 months ago (2015-01-26 14:20:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 14:21:06 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ae22d7f8739fe838fafb2d118f9b8a316403383b Cr-Commit-Position: refs/heads/master@{#26271}
5 years, 11 months ago (2015-01-26 14:21:18 UTC) #6
tandrii(chromium)
lgtm https://codereview.chromium.org/868473004/diff/1/tools/release/releases.py File tools/release/releases.py (right): https://codereview.chromium.org/868473004/diff/1/tools/release/releases.py#newcode173 tools/release/releases.py:173: "master_position": master_position, oh, the other CL didn't have ...
5 years, 11 months ago (2015-01-26 14:33:14 UTC) #7
Michael Achenbach
5 years, 11 months ago (2015-01-26 14:59:13 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/868473004/diff/1/tools/release/releases.py
File tools/release/releases.py (right):

https://codereview.chromium.org/868473004/diff/1/tools/release/releases.py#ne...
tools/release/releases.py:173: "master_position": master_position,
On 2015/01/26 14:33:13, tandrii(chromium) wrote:
> oh, the other CL didn't have that key change. Now it's clear :)

Yes - because that's an api change as the version spreadsheet reads these keys.

Powered by Google App Engine