Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 868473002: [Views] Don't reset button state after dragging if the button is disabled. (Closed)

Created:
5 years, 11 months ago by Devlin
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Views] Don't reset button state after dragging if the button is disabled. Committed: https://crrev.com/c7ad8c20af672e561d186dc21c422e50ce9be5a8 Cr-Commit-Position: refs/heads/master@{#313580}

Patch Set 1 #

Patch Set 2 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/views/controls/button/custom_button.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 23 (10 generated)
Devlin
Scott, please take a look when you get a chance. :)
5 years, 11 months ago (2015-01-21 23:27:45 UTC) #2
sky
LGTM
5 years, 11 months ago (2015-01-22 17:24:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868473002/1
5 years, 11 months ago (2015-01-22 17:26:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/116653) linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/102454) Try ...
5 years, 11 months ago (2015-01-22 18:48:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868473002/1
5 years, 11 months ago (2015-01-22 18:50:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/116653) linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/102454)
5 years, 11 months ago (2015-01-22 18:51:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868473002/1
5 years, 11 months ago (2015-01-23 01:12:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/114082) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/97874) Try ...
5 years, 11 months ago (2015-01-23 05:37:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868473002/1
5 years, 11 months ago (2015-01-23 21:13:16 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/114082) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/97874)
5 years, 11 months ago (2015-01-23 21:13:54 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868473002/20001
5 years, 10 months ago (2015-01-28 21:00:40 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 21:05:24 UTC) #22
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 21:06:27 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7ad8c20af672e561d186dc21c422e50ce9be5a8
Cr-Commit-Position: refs/heads/master@{#313580}

Powered by Google App Engine
This is Rietveld 408576698