Issue 868463010: Move gesture recognition from WindowManagerApp to Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 868463010: Move gesture recognition from WindowManagerApp to Sky (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Move gesture recognition from WindowManagerApp to Sky In order to have a high-quality gesture system, we need to know many details about the fine-grained structure of applications. For example, different parts of the view might be interested in recognizing different gestures and when you recognize a certain gesture depends on the set of possible gestures. This CL is a first step towards implementing https://github.com/domokit/mojo/blob/master/sky/specs/gestures.md by moving the gesture recognition into Sky where finer-grained information will be available. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/384d0955f617528612e78cb60c50dc6c9f2038c2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -32 lines)			Patch
M	services/window_manager/window_manager_app.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	services/window_manager/window_manager_app.cc	View	3 chunks	+0 lines, -22 lines	0 comments	Download
M	sky/viewer/BUILD.gn	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	sky/viewer/document_view.h	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	sky/viewer/document_view.cc	View	4 chunks	+28 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

abarth-chromium

5 years, 10 months ago (2015-01-29 22:52:19 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
384d0955f617528612e78cb60c50dc6c9f2038c2 (presubmit successful).