Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: shell/in_process_dynamic_service_runner.cc

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/in_process_dynamic_service_runner.cc
diff --git a/shell/in_process_dynamic_service_runner.cc b/shell/in_process_dynamic_service_runner.cc
index cdcbd012c6c7b2eac84f860f4e93d6cea897d402..96aca376b00a6f60fe0fa0a2c6d62182f7cd78da 100644
--- a/shell/in_process_dynamic_service_runner.cc
+++ b/shell/in_process_dynamic_service_runner.cc
@@ -30,12 +30,12 @@ InProcessDynamicServiceRunner::~InProcessDynamicServiceRunner() {
void InProcessDynamicServiceRunner::Start(
const base::FilePath& app_path,
- ScopedMessagePipeHandle service_handle,
+ InterfaceRequest<Application> application_request,
const base::Closure& app_completed_callback) {
app_path_ = app_path;
- DCHECK(!service_handle_.is_valid());
- service_handle_ = service_handle.Pass();
+ DCHECK(!application_request_.is_pending());
+ application_request_ = application_request.Pass();
DCHECK(app_completed_callback_runner_.is_null());
app_completed_callback_runner_ =
@@ -52,7 +52,7 @@ void InProcessDynamicServiceRunner::Run() {
<< app_path_.value()
<< " thread id=" << base::PlatformThread::CurrentId();
- app_library_.Reset(LoadAndRunService(app_path_, service_handle_.Pass()));
+ app_library_.Reset(LoadAndRunService(app_path_, application_request_.Pass()));
app_completed_callback_runner_.Run();
app_completed_callback_runner_.Reset();
}

Powered by Google App Engine
This is Rietveld 408576698