Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: shell/dynamic_service_runner.h

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/dynamic_service_runner.h
diff --git a/shell/dynamic_service_runner.h b/shell/dynamic_service_runner.h
index 7408789ca3253a6e175a833e0552481d03d28ea5..3abb6f706d418a74e1f5ef90f8cdd22d2ec2373f 100644
--- a/shell/dynamic_service_runner.h
+++ b/shell/dynamic_service_runner.h
@@ -8,6 +8,7 @@
#include "base/callback_forward.h"
#include "base/memory/scoped_ptr.h"
#include "base/native_library.h"
+#include "mojo/public/cpp/bindings/interface_request.h"
#include "mojo/public/cpp/system/core.h"
namespace base {
@@ -15,6 +16,8 @@ class FilePath;
}
namespace mojo {
+class Application;
+
namespace shell {
class Context;
@@ -29,7 +32,7 @@ class DynamicServiceRunner {
// runs it on some other thread/process. |app_completed_callback| is posted
// (to the thread on which |Start()| was called) after |MojoMain()| completes.
virtual void Start(const base::FilePath& app_path,
- ScopedMessagePipeHandle service_handle,
+ InterfaceRequest<Application> application_request,
const base::Closure& app_completed_callback) = 0;
// Loads the service in the DSO specificed by |app_path| and prepares it for
@@ -39,7 +42,7 @@ class DynamicServiceRunner {
// thread is destroyed and any thread-local destructors have been executed.
static base::NativeLibrary LoadAndRunService(
const base::FilePath& app_path,
- ScopedMessagePipeHandle service_handle);
+ InterfaceRequest<Application> application_request);
};
class DynamicServiceRunnerFactory {

Powered by Google App Engine
This is Rietveld 408576698