Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: shell/dynamic_application_loader_unittest.cc

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/dynamic_application_loader_unittest.cc
diff --git a/shell/dynamic_application_loader_unittest.cc b/shell/dynamic_application_loader_unittest.cc
index 2ce00628fa6a77e8d503da2d7481856454245134..729d1e6b069a8baf59fdac8f6d3cea414801e7d0 100644
--- a/shell/dynamic_application_loader_unittest.cc
+++ b/shell/dynamic_application_loader_unittest.cc
@@ -35,7 +35,7 @@ class TestDynamicServiceRunner : public DynamicServiceRunner {
base::MessageLoop::current()->Quit();
}
void Start(const base::FilePath& app_path,
- ScopedMessagePipeHandle service_handle,
+ InterfaceRequest<Application> application_request,
const base::Closure& app_completed_callback) override {
state_->runner_was_started = true;
}
@@ -82,9 +82,8 @@ TEST_F(DynamicApplicationLoaderTest, DoesNotExist) {
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
base::FilePath nonexistent_file(FILE_PATH_LITERAL("nonexistent.txt"));
GURL url(FilePathToFileURL(temp_dir.path().Append(nonexistent_file)));
- ShellPtr shell;
- auto throwaway = GetProxy(&shell);
- loader_->Load(context_.application_manager(), url, shell.Pass(),
+ ApplicationPtr application;
+ loader_->Load(context_.application_manager(), url, GetProxy(&application),
ApplicationLoader::SimpleLoadCallback());
EXPECT_FALSE(state_.runner_was_created);
EXPECT_FALSE(state_.runner_was_started);

Powered by Google App Engine
This is Rietveld 408576698