Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: shell/android/background_application_loader.h

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/android/background_application_loader.h
diff --git a/shell/android/background_application_loader.h b/shell/android/background_application_loader.h
index 26280e84bacc2c1beee87cb4992d7804030fdc71..a4c07b84df2e2c14073437a774d712c423197607 100644
--- a/shell/android/background_application_loader.h
+++ b/shell/android/background_application_loader.h
@@ -26,7 +26,7 @@ class MOJO_APPLICATION_MANAGER_EXPORT BackgroundApplicationLoader
// ApplicationLoader overrides:
void Load(ApplicationManager* manager,
const GURL& url,
- ShellPtr shell,
+ InterfaceRequest<Application> application_request,
LoadCallback callback) override;
void OnApplicationError(ApplicationManager* manager,
const GURL& url) override;
@@ -39,9 +39,10 @@ class MOJO_APPLICATION_MANAGER_EXPORT BackgroundApplicationLoader
// to |background_loader_| to do the actual loading.
// TODO: having this code take a |manager| is fragile (as ApplicationManager
// isn't thread safe).
- void LoadOnBackgroundThread(ApplicationManager* manager,
- const GURL& url,
- ShellPtr shell);
+ void LoadOnBackgroundThread(
+ ApplicationManager* manager,
+ const GURL& url,
+ InterfaceRequest<Application> application_request);
void OnApplicationErrorOnBackgroundThread(ApplicationManager* manager,
const GURL& url);
bool quit_on_shutdown_;

Powered by Google App Engine
This is Rietveld 408576698