Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: services/js/js_app.h

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/js/js_app.h
diff --git a/services/js/js_app.h b/services/js/js_app.h
index 49626ef1e7f8ff607e52ed40ae6c4a99e88b1d42..8e7e7930689aa551f3808dc7727cca7c4da851d1 100644
--- a/services/js/js_app.h
+++ b/services/js/js_app.h
@@ -25,7 +25,8 @@ class ApplicationDelegateImpl;
class JSApp : public mojo::ContentHandlerFactory::HandledApplicationHolder {
public:
- JSApp(mojo::ShellPtr shell, mojo::URLResponsePtr response);
+ JSApp(mojo::InterfaceRequest<mojo::Application> application_request,
+ mojo::URLResponsePtr response);
virtual ~JSApp();
private:
@@ -33,7 +34,7 @@ class JSApp : public mojo::ContentHandlerFactory::HandledApplicationHolder {
void OnAppLoaded(std::string url, v8::Handle<v8::Value> module);
- mojo::ShellPtr shell_;
+ mojo::InterfaceRequest<mojo::Application> application_request_;
JSAppRunnerDelegate runner_delegate_;
gin::IsolateHolder isolate_holder_;
scoped_ptr<gin::ShellRunner> shell_runner_;

Powered by Google App Engine
This is Rietveld 408576698