Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: services/dart/dart_app.cc

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/dart/dart_app.cc
diff --git a/services/dart/dart_app.cc b/services/dart/dart_app.cc
index e1c06ebe9b2f3a0430ce0807bbaf6c92a3c08592..8f00db8067a4de343894dbd2ac5048e753921e80 100644
--- a/services/dart/dart_app.cc
+++ b/services/dart/dart_app.cc
@@ -14,10 +14,13 @@
#include "mojo/dart/embedder/isolate_data.h"
#include "mojo/public/cpp/bindings/interface_request.h"
+using mojo::Application;
+
namespace dart {
-DartApp::DartApp(mojo::ShellPtr shell, mojo::URLResponsePtr response)
- : shell_(shell.Pass()) {
+DartApp::DartApp(mojo::InterfaceRequest<Application> application_request,
+ mojo::URLResponsePtr response)
+ : application_request_(application_request.Pass()) {
DCHECK(!response.is_null());
std::string url(response->url);
std::string source;
@@ -46,7 +49,7 @@ DartApp::~DartApp() {
void DartApp::OnAppLoaded() {
char* error = nullptr;
- config_.handle = shell_.PassMessagePipe().release().value();
+ config_.handle = application_request_.PassMessagePipe().release().value();
config_.error = &error;
bool success = mojo::dart::DartController::RunDartScript(config_);
if (!success) {

Powered by Google App Engine
This is Rietveld 408576698