Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: mojo/application/application_runner_chromium.cc

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/application/application_runner_chromium.cc
diff --git a/mojo/application/application_runner_chromium.cc b/mojo/application/application_runner_chromium.cc
index 3fde912493a1226da03d9183fea8135922e11319..069ff90e346b73affdf6a940c690ce63cb747a9e 100644
--- a/mojo/application/application_runner_chromium.cc
+++ b/mojo/application/application_runner_chromium.cc
@@ -37,7 +37,8 @@ void ApplicationRunnerChromium::set_message_loop_type(
message_loop_type_ = type;
}
-MojoResult ApplicationRunnerChromium::Run(MojoHandle shell_handle) {
+MojoResult ApplicationRunnerChromium::Run(
+ MojoHandle application_request_handle) {
DCHECK(!has_run_);
has_run_ = true;
@@ -55,9 +56,9 @@ MojoResult ApplicationRunnerChromium::Run(MojoHandle shell_handle) {
else
loop.reset(new base::MessageLoop(message_loop_type_));
- ShellPtr shell;
- shell.Bind(MakeScopedHandle(MessagePipeHandle(shell_handle)));
- ApplicationImpl impl(delegate_.get(), shell.Pass());
+ ApplicationImpl impl(delegate_.get(),
+ MakeRequest<Application>(MakeScopedHandle(
+ MessagePipeHandle(application_request_handle))));
loop->Run();
}
delegate_.reset();

Powered by Google App Engine
This is Rietveld 408576698