Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc
diff --git a/mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc b/mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc
index 50ffd09d124e7a5ec8a0c080269b68849b90edf4..bc694646fd8a020ac2ef286432d8f9be0926b130 100644
--- a/mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc
+++ b/mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc
@@ -63,10 +63,11 @@ class ConnectApplicationLoader : public ApplicationLoader,
// Overridden from ApplicationLoader:
void Load(ApplicationManager* manager,
const GURL& url,
- ShellPtr shell,
+ InterfaceRequest<Application> application_request,
LoadCallback callback) override {
- ASSERT_TRUE(shell);
- scoped_ptr<ApplicationImpl> app(new ApplicationImpl(this, shell.Pass()));
+ ASSERT_TRUE(application_request.is_pending());
+ scoped_ptr<ApplicationImpl> app(
+ new ApplicationImpl(this, application_request.Pass()));
apps_.push_back(app.release());
}

Powered by Google App Engine
This is Rietveld 408576698