Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Side by Side Diff: shell/application_manager/shell_impl.h

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SHELL_APPLICATION_MANAGER_SHELL_IMPL_H_ 5 #ifndef SHELL_APPLICATION_MANAGER_SHELL_IMPL_H_
6 #define SHELL_APPLICATION_MANAGER_SHELL_IMPL_H_ 6 #define SHELL_APPLICATION_MANAGER_SHELL_IMPL_H_
7 7
8 #include "mojo/public/cpp/bindings/binding.h" 8 #include "mojo/public/cpp/bindings/binding.h"
9 #include "mojo/public/cpp/bindings/error_handler.h" 9 #include "mojo/public/cpp/bindings/error_handler.h"
10 #include "mojo/public/interfaces/application/application.mojom.h" 10 #include "mojo/public/interfaces/application/application.mojom.h"
11 #include "mojo/public/interfaces/application/shell.mojom.h" 11 #include "mojo/public/interfaces/application/shell.mojom.h"
12 #include "url/gurl.h" 12 #include "url/gurl.h"
13 13
14 namespace mojo { 14 namespace mojo {
15 class ApplicationManager; 15 class ApplicationManager;
16 16
17 class ShellImpl : public Shell, public ErrorHandler { 17 class ShellImpl : public Shell, public ErrorHandler {
18 public: 18 public:
19 ShellImpl(InterfaceRequest<Shell> shell_request, 19 ShellImpl(ApplicationPtr application,
20 ApplicationManager* manager, 20 ApplicationManager* manager,
21 const GURL& requested_url, 21 const GURL& requested_url,
22 const GURL& url); 22 const GURL& url);
23 23
24 ~ShellImpl() override; 24 ~ShellImpl() override;
25 25
26 void InitializeApplication(Array<String> args);
27
26 void ConnectToClient(const GURL& requestor_url, 28 void ConnectToClient(const GURL& requestor_url,
27 InterfaceRequest<ServiceProvider> services, 29 InterfaceRequest<ServiceProvider> services,
28 ServiceProviderPtr exposed_services); 30 ServiceProviderPtr exposed_services);
29 31
30 Application* client() { return binding_.client(); } 32 Application* application() { return application_.get(); }
31 const GURL& url() const { return url_; } 33 const GURL& url() const { return url_; }
32 const GURL& requested_url() const { return requested_url_; } 34 const GURL& requested_url() const { return requested_url_; }
33 35
34 private: 36 private:
35 // Shell implementation: 37 // Shell implementation:
36 void ConnectToApplication(const String& app_url, 38 void ConnectToApplication(const String& app_url,
37 InterfaceRequest<ServiceProvider> services, 39 InterfaceRequest<ServiceProvider> services,
38 ServiceProviderPtr exposed_services) override; 40 ServiceProviderPtr exposed_services) override;
39 41
40 // ErrorHandler implementation: 42 // ErrorHandler implementation:
41 void OnConnectionError() override; 43 void OnConnectionError() override;
42 44
43 ApplicationManager* const manager_; 45 ApplicationManager* const manager_;
44 const GURL requested_url_; 46 const GURL requested_url_;
45 const GURL url_; 47 const GURL url_;
48 ApplicationPtr application_;
46 Binding<Shell> binding_; 49 Binding<Shell> binding_;
47 50
48 DISALLOW_COPY_AND_ASSIGN(ShellImpl); 51 DISALLOW_COPY_AND_ASSIGN(ShellImpl);
49 }; 52 };
50 53
51 } // namespace mojo 54 } // namespace mojo
52 55
53 #endif // SHELL_APPLICATION_MANAGER_SHELL_IMPL_H_ 56 #endif // SHELL_APPLICATION_MANAGER_SHELL_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698