Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: shell/application_manager/shell_impl.cc

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "shell/application_manager/shell_impl.h" 5 #include "shell/application_manager/shell_impl.h"
6 6
7 #include "mojo/common/common_type_converters.h" 7 #include "mojo/common/common_type_converters.h"
8 #include "mojo/services/content_handler/public/interfaces/content_handler.mojom. h" 8 #include "mojo/services/content_handler/public/interfaces/content_handler.mojom. h"
9 #include "shell/application_manager/application_manager.h" 9 #include "shell/application_manager/application_manager.h"
10 10
11 namespace mojo { 11 namespace mojo {
12 12
13 ShellImpl::ShellImpl(InterfaceRequest<Shell> shell_request, 13 ShellImpl::ShellImpl(ApplicationPtr application,
14 ApplicationManager* manager, 14 ApplicationManager* manager,
15 const GURL& requested_url, 15 const GURL& requested_url,
16 const GURL& url) 16 const GURL& url)
17 : manager_(manager), 17 : manager_(manager),
18 requested_url_(requested_url), 18 requested_url_(requested_url),
19 url_(url), 19 url_(url),
20 binding_(this, shell_request.Pass()) { 20 application_(application.Pass()),
21 binding_(this) {
21 binding_.set_error_handler(this); 22 binding_.set_error_handler(this);
22 } 23 }
23 24
24 ShellImpl::~ShellImpl() { 25 ShellImpl::~ShellImpl() {
25 } 26 }
26 27
28 void ShellImpl::InitializeApplication(Array<String> args) {
29 ShellPtr shell;
30 binding_.Bind(GetProxy(&shell));
31 application_->Initialize(shell.Pass(), args.Pass());
32 }
33
27 void ShellImpl::ConnectToClient(const GURL& requestor_url, 34 void ShellImpl::ConnectToClient(const GURL& requestor_url,
28 InterfaceRequest<ServiceProvider> services, 35 InterfaceRequest<ServiceProvider> services,
29 ServiceProviderPtr exposed_services) { 36 ServiceProviderPtr exposed_services) {
30 client()->AcceptConnection(String::From(requestor_url), services.Pass(), 37 application_->AcceptConnection(String::From(requestor_url), services.Pass(),
31 exposed_services.Pass()); 38 exposed_services.Pass());
32 } 39 }
33 40
34 // Shell implementation: 41 // Shell implementation:
35 void ShellImpl::ConnectToApplication(const String& app_url, 42 void ShellImpl::ConnectToApplication(const String& app_url,
36 InterfaceRequest<ServiceProvider> services, 43 InterfaceRequest<ServiceProvider> services,
37 ServiceProviderPtr exposed_services) { 44 ServiceProviderPtr exposed_services) {
38 GURL app_gurl(app_url); 45 GURL app_gurl(app_url);
39 if (!app_gurl.is_valid()) { 46 if (!app_gurl.is_valid()) {
40 LOG(ERROR) << "Error: invalid URL: " << app_url; 47 LOG(ERROR) << "Error: invalid URL: " << app_url;
41 return; 48 return;
42 } 49 }
43 manager_->ConnectToApplication(app_gurl, url_, services.Pass(), 50 manager_->ConnectToApplication(app_gurl, url_, services.Pass(),
44 exposed_services.Pass()); 51 exposed_services.Pass());
45 } 52 }
46 53
47 void ShellImpl::OnConnectionError() { 54 void ShellImpl::OnConnectionError() {
48 manager_->OnShellImplError(this); 55 manager_->OnShellImplError(this);
49 } 56 }
50 57
51 } // namespace mojo 58 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698