Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: shell/android/ui_application_loader_android.cc

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "shell/android/ui_application_loader_android.h" 5 #include "shell/android/ui_application_loader_android.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "shell/application_manager/application_manager.h" 9 #include "shell/application_manager/application_manager.h"
10 10
11 namespace mojo { 11 namespace mojo {
12 12
13 UIApplicationLoader::UIApplicationLoader( 13 UIApplicationLoader::UIApplicationLoader(
14 scoped_ptr<ApplicationLoader> real_loader, 14 scoped_ptr<ApplicationLoader> real_loader,
15 base::MessageLoop* ui_message_loop) 15 base::MessageLoop* ui_message_loop)
16 : loader_(real_loader.Pass()), ui_message_loop_(ui_message_loop) { 16 : loader_(real_loader.Pass()), ui_message_loop_(ui_message_loop) {
17 } 17 }
18 18
19 UIApplicationLoader::~UIApplicationLoader() { 19 UIApplicationLoader::~UIApplicationLoader() {
20 ui_message_loop_->PostTask( 20 ui_message_loop_->PostTask(
21 FROM_HERE, base::Bind(&UIApplicationLoader::ShutdownOnUIThread, 21 FROM_HERE, base::Bind(&UIApplicationLoader::ShutdownOnUIThread,
22 base::Unretained(this))); 22 base::Unretained(this)));
23 } 23 }
24 24
25 void UIApplicationLoader::Load(ApplicationManager* manager, 25 void UIApplicationLoader::Load(
26 const GURL& url, 26 ApplicationManager* manager,
27 ShellPtr shell, 27 const GURL& url,
28 LoadCallback callback) { 28 InterfaceRequest<Application> application_request,
29 DCHECK(shell); 29 LoadCallback callback) {
30 DCHECK(application_request.is_pending());
30 ui_message_loop_->PostTask( 31 ui_message_loop_->PostTask(
31 FROM_HERE, 32 FROM_HERE,
32 base::Bind(&UIApplicationLoader::LoadOnUIThread, base::Unretained(this), 33 base::Bind(&UIApplicationLoader::LoadOnUIThread, base::Unretained(this),
33 manager, url, base::Passed(&shell))); 34 manager, url, base::Passed(&application_request)));
34 } 35 }
35 36
36 void UIApplicationLoader::OnApplicationError(ApplicationManager* manager, 37 void UIApplicationLoader::OnApplicationError(ApplicationManager* manager,
37 const GURL& url) { 38 const GURL& url) {
38 ui_message_loop_->PostTask( 39 ui_message_loop_->PostTask(
39 FROM_HERE, base::Bind(&UIApplicationLoader::OnApplicationErrorOnUIThread, 40 FROM_HERE, base::Bind(&UIApplicationLoader::OnApplicationErrorOnUIThread,
40 base::Unretained(this), manager, url)); 41 base::Unretained(this), manager, url));
41 } 42 }
42 43
43 void UIApplicationLoader::LoadOnUIThread(ApplicationManager* manager, 44 void UIApplicationLoader::LoadOnUIThread(
44 const GURL& url, 45 ApplicationManager* manager,
45 ShellPtr shell) { 46 const GURL& url,
46 loader_->Load(manager, url, shell.Pass(), SimpleLoadCallback()); 47 InterfaceRequest<Application> application_request) {
48 loader_->Load(manager, url, application_request.Pass(), SimpleLoadCallback());
47 } 49 }
48 50
49 void UIApplicationLoader::OnApplicationErrorOnUIThread( 51 void UIApplicationLoader::OnApplicationErrorOnUIThread(
50 ApplicationManager* manager, 52 ApplicationManager* manager,
51 const GURL& url) { 53 const GURL& url) {
52 loader_->OnApplicationError(manager, url); 54 loader_->OnApplicationError(manager, url);
53 } 55 }
54 56
55 void UIApplicationLoader::ShutdownOnUIThread() { 57 void UIApplicationLoader::ShutdownOnUIThread() {
56 // Destroy |loader_| on the thread it's actually used on. 58 // Destroy |loader_| on the thread it's actually used on.
57 loader_.reset(); 59 loader_.reset();
58 } 60 }
59 61
60 } // namespace mojo 62 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698