Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: mojo/services/public/js/application.js

Issue 868463008: Remove Client relationship between mojo.Shell/mojo.Application (Closed) Base URL: git@github.com:domokit/mojo.git@app_impl_init
Patch Set: fix android Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 define("mojo/services/public/js/application", [ 5 define("mojo/services/public/js/application", [
6 "mojo/public/js/bindings",
7 "mojo/public/js/core",
8 "mojo/public/js/connection",
6 "mojo/public/js/threading", 9 "mojo/public/js/threading",
10 "mojo/public/interfaces/application/application.mojom",
7 "mojo/services/public/js/service_provider", 11 "mojo/services/public/js/service_provider",
8 "mojo/services/public/js/shell", 12 "mojo/services/public/js/shell",
9 ], function(threading, serviceProvider, shell) { 13 ], function(bindings, core, connection, threading, applicationMojom, serviceProv ider, shell) {
10 14
15 const ApplicationInterface = applicationMojom.Application;
16 const ProxyBindings = bindings.ProxyBindings;
11 const ServiceProvider = serviceProvider.ServiceProvider; 17 const ServiceProvider = serviceProvider.ServiceProvider;
12 const Shell = shell.Shell; 18 const Shell = shell.Shell;
13 19
14 class Application { 20 class Application {
15 constructor(shellHandle, url) { 21 constructor(appRequestHandle, url) {
16 this.url = url; 22 this.url = url;
17 this.serviceProviders = []; 23 this.serviceProviders = [];
18 this.exposedServiceProviders = []; 24 this.exposedServiceProviders = [];
19 this.shellHandle_ = shellHandle; 25 this.appRequestHandle_ = appRequestHandle;
20 this.shell = new Shell(shellHandle, { 26 this.appStub_ =
21 initialize: this.initialize.bind(this), 27 connection.bindHandleToStub(appRequestHandle, ApplicationInterface);
22 acceptConnection: this.doAcceptConnection.bind(this), 28 bindings.StubBindings(this.appStub_).delegate = {
23 }); 29 initialize: this.doInitialize.bind(this),
30 acceptConnection: this.doAcceptConnection.bind(this),
31 };
24 } 32 }
25 33
26 initialize(args) { 34 doInitialize(shellProxy, args) {
35 this.shellProxy_ = shellProxy;
36 this.shell = new Shell(shellProxy);
37 this.initialize(args);
27 } 38 }
28 39
40 initialize(args) {}
41
29 // The mojom signature of this function is: 42 // The mojom signature of this function is:
30 // AcceptConnection(string requestor_url, 43 // AcceptConnection(string requestor_url,
31 // ServiceProvider&? services, 44 // ServiceProvider&? services,
32 // ServiceProvider? exposed_services); 45 // ServiceProvider? exposed_services);
33 // 46 //
34 // We want to bind |services| to our js implementation of ServiceProvider 47 // We want to bind |services| to our js implementation of ServiceProvider
35 // and store |exposed_services| so we can request services of the connecting 48 // and store |exposed_services| so we can request services of the connecting
36 // application. 49 // application.
37 doAcceptConnection(requestorUrl, servicesRequest, exposedServicesProxy) { 50 doAcceptConnection(requestorUrl, servicesRequest, exposedServicesProxy) {
38 // Construct a new js ServiceProvider that can make outgoing calls on 51 // Construct a new js ServiceProvider that can make outgoing calls on
39 // exposedServicesProxy. 52 // exposedServicesProxy.
40 var serviceProvider = 53 var serviceProvider =
41 new ServiceProvider(servicesRequest, exposedServicesProxy); 54 new ServiceProvider(servicesRequest, exposedServicesProxy);
42 this.serviceProviders.push(serviceProvider); 55 this.serviceProviders.push(serviceProvider);
43 this.acceptConnection(requestorUrl, serviceProvider); 56 this.acceptConnection(requestorUrl, serviceProvider);
44 } 57 }
45 58
46 acceptConnection(requestorUrl, serviceProvider) { 59 acceptConnection(requestorUrl, serviceProvider) {}
47 }
48 60
49 quit() { 61 quit() {
50 this.serviceProviders.forEach(function(sp) { 62 this.serviceProviders.forEach(function(sp) {
51 sp.close(); 63 sp.close();
52 }); 64 });
53 this.shell.close(); 65 this.shell.close();
66 core.close(this.appRequestHandle_);
54 threading.quit(); 67 threading.quit();
55 } 68 }
56 } 69 }
57 70
58 var exports = {}; 71 var exports = {};
59 exports.Application = Application; 72 exports.Application = Application;
60 return exports; 73 return exports;
61 }); 74 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698