Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerError.cpp

Issue 868463004: ServiceWorker: add ServiceWorkerClients.claim() support (1/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: change error type Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerError.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerError.cpp b/Source/modules/serviceworkers/ServiceWorkerError.cpp
index 648e308672e9a285cb307c30be394bf7a82ea1d8..5203632e94b4c205067fd9ed225595afe8292bb4 100644
--- a/Source/modules/serviceworkers/ServiceWorkerError.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerError.cpp
@@ -65,6 +65,8 @@ PassRefPtrWillBeRawPtr<DOMException> ServiceWorkerError::take(ScriptPromiseResol
return createException(NotFoundError, "The specified Service Worker resource was not found.", webError->message);
case WebServiceWorkerError::ErrorTypeSecurity:
return createException(SecurityError, "The Service Worker security policy prevented an action.", webError->message);
+ case WebServiceWorkerError::ErrorTypeState:
+ return createException(InvalidStateError, "The Service Worker operation failed by invalid state.", webError->message);
mlamouri (slow - plz ping) 2015/01/23 10:08:08 nit: the error message doesn't sound correct but I
jsbell 2015/01/24 00:42:16 +1 Given the text in the specification leading to
jsbell 2015/01/24 01:15:01 Ah, since this is just the default message, and th
falken 2015/01/26 04:55:11 Right, jsbell's message is good. We've actually hi
xiang 2015/01/26 06:47:54 Done.
case WebServiceWorkerError::ErrorTypeUnknown:
return createException(UnknownError, "An unknown error occurred within Service Worker.", webError->message);
}

Powered by Google App Engine
This is Rietveld 408576698