public/platform/WebServiceWorkerClientsClaimCallbacks.h - Issue 868463004: ServiceWorker: add ServiceWorkerClients.claim() support (1/3).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: public/platform/WebServiceWorkerClientsClaimCallbacks.h

Issue 868463004: ServiceWorker: add ServiceWorkerClients.claim() support (1/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: change error type Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WebServiceWorkerClientsClaimCallbacks_h

	6 #define WebServiceWorkerClientsClaimCallbacks_h

	7

	8 #include "public/platform/WebCallbacks.h"

	9

	10 namespace blink {

	11

	12 struct WebServiceWorkerError;

	13

	14 using WebServiceWorkerClientsClaimCallbacks = WebCallbacks<void, WebServiceWorke rError>;
	mlamouri (slow - plz ping) 2015/01/23 10:08:08 Would that make sense to have that in WebServiceWo Would that make sense to have that in WebServiceWorkerContextClient.h instead of creating a new file? xiang 2015/01/26 06:47:54 I thought this header will also be used by modules Show quoted text On 2015/01/23 10:08:08, Mounir Lamouri wrote: > Would that make sense to have that in WebServiceWorkerContextClient.h instead of > creating a new file? I thought this header will also be used by modules/serviceworker/ which should not depends on public/web headers, so created a new one and put it to public/platform.
	15

	16 } // namespace blink

	17

	18 #endif // WebServiceWorkerClientsClaimCallbacks_h

OLD	NEW