Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: Source/core/editing/iterators/CharacterIterator.cpp

Issue 868463002: Support WholeWord in window.find() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: bug fix Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/iterators/CharacterIterator.cpp
diff --git a/Source/core/editing/iterators/CharacterIterator.cpp b/Source/core/editing/iterators/CharacterIterator.cpp
index 9d5e55558487e6d80b2dc1c8336af2fcf4b2af37..87b26095c342440cdd5d4fcff826672ee3d537e0 100644
--- a/Source/core/editing/iterators/CharacterIterator.cpp
+++ b/Source/core/editing/iterators/CharacterIterator.cpp
@@ -475,7 +475,11 @@ inline bool SearchBuffer::isWordStartMatch(size_t start, size_t length) const
size_t wordBreakSearchStart = start + length;
while (wordBreakSearchStart > start)
wordBreakSearchStart = findNextWordFromIndex(m_buffer.data(), m_buffer.size(), wordBreakSearchStart, false /* backwards */);
- return wordBreakSearchStart == start;
+ if (wordBreakSearchStart != start)
+ return false;
+ if (m_options & WholeWord)
+ return static_cast<int>(start + length) == findWordEndBoundary(m_buffer.data(), m_buffer.size(), wordBreakSearchStart);
+ return true;
}
inline size_t SearchBuffer::search(size_t& start)

Powered by Google App Engine
This is Rietveld 408576698