Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 868463002: Support WholeWord in window.find() (Closed)

Created:
5 years, 11 months ago by c.shu
Modified:
5 years, 7 months ago
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Support WholeWord in window.find() Also removed redundant findString API. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194953

Patch Set 1 #

Patch Set 2 : bug fix #

Total comments: 1

Patch Set 3 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M LayoutTests/fast/text/window-find.html View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/editing/Editor.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/Editor.cpp View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FindOptions.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/editing/iterators/CharacterIterator.cpp View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 2 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
c.shu
5 years, 11 months ago (2015-01-21 23:18:07 UTC) #1
c.shu
5 years, 11 months ago (2015-01-22 16:07:08 UTC) #3
Yuta Kitamura
+yosin
5 years, 11 months ago (2015-01-23 07:48:12 UTC) #5
yosin_UTC9
lgtm Thanks!
5 years, 11 months ago (2015-01-26 01:19:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868463002/20001
5 years, 11 months ago (2015-01-26 15:36:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/25008)
5 years, 11 months ago (2015-01-26 15:42:08 UTC) #10
c.shu
On 2015/01/26 15:42:08, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-26 15:47:20 UTC) #11
rwlbuis
On 2015/01/26 15:47:20, c.shu wrote: > On 2015/01/26 15:42:08, I haz the power (commit-bot) wrote: ...
5 years, 8 months ago (2015-04-21 14:21:53 UTC) #12
rwlbuis
On 2015/04/21 14:21:53, rwlbuis wrote: > On 2015/01/26 15:47:20, c.shu wrote: > > On 2015/01/26 ...
5 years, 7 months ago (2015-04-28 21:11:57 UTC) #13
yosin_UTC9
Sorry for late response. We would like to have this improvement. I'm turning on commit ...
5 years, 7 months ago (2015-04-30 02:10:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868463002/20001
5 years, 7 months ago (2015-04-30 02:10:18 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/32387)
5 years, 7 months ago (2015-04-30 02:19:49 UTC) #18
Yuta Kitamura
lgtm with nits https://codereview.chromium.org/868463002/diff/20001/Source/core/frame/LocalDOMWindow.cpp File Source/core/frame/LocalDOMWindow.cpp (right): https://codereview.chromium.org/868463002/diff/20001/Source/core/frame/LocalDOMWindow.cpp#newcode1114 Source/core/frame/LocalDOMWindow.cpp:1114: FindOptions options = (backwards ? Backwards ...
5 years, 7 months ago (2015-04-30 07:51:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868463002/40001
5 years, 7 months ago (2015-05-06 00:27:05 UTC) #22
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 02:01:54 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194953

Powered by Google App Engine
This is Rietveld 408576698