Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: runtime/vm/parser.cc

Issue 868453002: Rename is_visible to is_reflectable; use is_debuggable instead of is_reflectable (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/vm/type_cast_vm_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index 53841db997b827f35f0ee7808235b5c65ce70947..a0cc1a4120d5cc0ea217ec8f3854e2bbc5e248f0 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -1082,7 +1082,7 @@ ParsedFunction* Parser::ParseStaticFieldInitializer(const Field& field) {
// Since they are only executed once, we avoid optimizing
// and inlining them. After the field is initialized, the
// compiler can eliminate the call to the static initializer.
- initializer.set_is_visible(false);
+ initializer.set_is_reflectable(false);
initializer.set_is_debuggable(false);
initializer.SetIsOptimizable(false);
initializer.set_is_inlinable(false);
@@ -3652,7 +3652,7 @@ void Parser::ParseMethodOrConstructor(ClassDesc* members, MemberDesc* method) {
func.set_is_redirecting(is_redirecting);
func.set_modifier(async_modifier);
if (library_.is_dart_scheme() && library_.IsPrivate(*method->name)) {
- func.set_is_visible(false);
+ func.set_is_reflectable(false);
}
if (method->metadata_pos > 0) {
library_.AddFunctionMetadata(func, method->metadata_pos);
@@ -3778,7 +3778,7 @@ void Parser::ParseFieldDefinition(ClassDesc* members, MemberDesc* field) {
getter.set_result_type(*field->type);
getter.set_is_debuggable(false);
if (library_.is_dart_scheme() && library_.IsPrivate(*field->name)) {
- getter.set_is_visible(false);
+ getter.set_is_reflectable(false);
}
members->AddFunction(getter);
}
@@ -3824,7 +3824,7 @@ void Parser::ParseFieldDefinition(ClassDesc* members, MemberDesc* field) {
setter.set_result_type(Type::Handle(I, Type::VoidType()));
setter.set_is_debuggable(false);
if (library_.is_dart_scheme() && library_.IsPrivate(*field->name)) {
- setter.set_is_visible(false);
+ setter.set_is_reflectable(false);
}
AddFormalParamsToFunction(&params, setter);
members->AddFunction(setter);
@@ -4574,7 +4574,7 @@ void Parser::AddImplicitConstructor(const Class& cls) {
ctor.set_end_token_pos(ctor.token_pos());
ctor.set_is_debuggable(false);
if (library_.is_dart_scheme() && library_.IsPrivate(ctor_name)) {
- ctor.set_is_visible(false);
+ ctor.set_is_reflectable(false);
}
ParamList params;
@@ -5153,7 +5153,7 @@ void Parser::ParseTopLevelVariable(TopLevel* top_level,
getter.set_result_type(type);
getter.set_is_debuggable(false);
if (library_.is_dart_scheme() && library_.IsPrivate(var_name)) {
- getter.set_is_visible(false);
+ getter.set_is_reflectable(false);
}
top_level->functions.Add(getter);
}
@@ -5277,11 +5277,8 @@ void Parser::ParseTopLevelFunction(TopLevel* top_level,
func.set_result_type(result_type);
func.set_end_token_pos(function_end_pos);
func.set_modifier(func_modifier);
- if (is_native) {
- func.set_is_debuggable(false);
- }
if (library_.is_dart_scheme() && library_.IsPrivate(func_name)) {
- func.set_is_visible(false);
+ func.set_is_reflectable(false);
}
AddFormalParamsToFunction(&params, func);
top_level->functions.Add(func);
@@ -5424,7 +5421,7 @@ void Parser::ParseTopLevelAccessor(TopLevel* top_level,
func.set_is_debuggable(false);
}
if (library_.is_dart_scheme() && library_.IsPrivate(accessor_name)) {
- func.set_is_visible(false);
+ func.set_is_reflectable(false);
}
AddFormalParamsToFunction(&params, func);
top_level->functions.Add(func);
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/vm/type_cast_vm_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698