Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: media/base/video_decoder.h

Issue 868443004: Document purpose of low_delay flag in VideoDecoder interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_VIDEO_DECODER_H_ 5 #ifndef MEDIA_BASE_VIDEO_DECODER_H_
6 #define MEDIA_BASE_VIDEO_DECODER_H_ 6 #define MEDIA_BASE_VIDEO_DECODER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // depends on |this|. 48 // depends on |this|.
49 virtual ~VideoDecoder(); 49 virtual ~VideoDecoder();
50 50
51 // Returns the name of the decoder for logging purpose. 51 // Returns the name of the decoder for logging purpose.
52 virtual std::string GetDisplayName() const = 0; 52 virtual std::string GetDisplayName() const = 0;
53 53
54 // Initializes a VideoDecoder with the given |config|, executing the 54 // Initializes a VideoDecoder with the given |config|, executing the
55 // |status_cb| upon completion. |output_cb| is called for each output frame 55 // |status_cb| upon completion. |output_cb| is called for each output frame
56 // decoded by Decode(). 56 // decoded by Decode().
57 // 57 //
58 // If |low_delay| is true then the decoder is not allowed to queue frames,
59 // except for out-of-order frames, i.e. if the next frame can be returned it
60 // must be returned without waiting for Decode() to be called again.
61 // Initialization should fail if |low_delay| is true and the decoder cannot
62 // satisfy the requirements above.
63 //
58 // Note: 64 // Note:
59 // 1) The VideoDecoder will be reinitialized if it was initialized before. 65 // 1) The VideoDecoder will be reinitialized if it was initialized before.
60 // Upon reinitialization, all internal buffered frames will be dropped. 66 // Upon reinitialization, all internal buffered frames will be dropped.
61 // 2) This method should not be called during pending decode or reset. 67 // 2) This method should not be called during pending decode or reset.
62 // 3) No VideoDecoder calls should be made before |status_cb| is executed. 68 // 3) No VideoDecoder calls should be made before |status_cb| is executed.
63 virtual void Initialize(const VideoDecoderConfig& config, 69 virtual void Initialize(const VideoDecoderConfig& config,
64 bool low_delay, 70 bool low_delay,
65 const PipelineStatusCB& status_cb, 71 const PipelineStatusCB& status_cb,
66 const OutputCB& output_cb) = 0; 72 const OutputCB& output_cb) = 0;
67 73
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 // Returns maximum number of parallel decode requests. 111 // Returns maximum number of parallel decode requests.
106 virtual int GetMaxDecodeRequests() const; 112 virtual int GetMaxDecodeRequests() const;
107 113
108 private: 114 private:
109 DISALLOW_COPY_AND_ASSIGN(VideoDecoder); 115 DISALLOW_COPY_AND_ASSIGN(VideoDecoder);
110 }; 116 };
111 117
112 } // namespace media 118 } // namespace media
113 119
114 #endif // MEDIA_BASE_VIDEO_DECODER_H_ 120 #endif // MEDIA_BASE_VIDEO_DECODER_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698