Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 868363003: Revert of Name V8 snapshot according to target architecture (32/64 bit). (Closed)

Created:
5 years, 10 months ago by boliu
Modified:
5 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Name V8 snapshot according to target architecture (32/64 bit). (patchset #5 id:80001 of https://codereview.chromium.org/903793002/) Reason for revert: Some target_arch constants are wrong/missing, causing build breaks on those architectures. Original issue's description: > Name V8 snapshot according to target architecture (32/64 bit). > > Renaming webview copy of V8 snapshot to be able to differentiate > between snapshots for 32- and 64 bit architectures. > This is done so that snapshots for different architectures can be > repacked into the same APK. > > BUG=455699 > > Committed: https://crrev.com/0ae506b5a6eae5cf0e440752a4fb99b35e2b0f05 > Cr-Commit-Position: refs/heads/master@{#315314} TBR=torne@chromium.org,rmcilroy@chromium.org,mef@chromium.org,kkimlabs@chromium.org,gsennton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455699 Committed: https://crrev.com/9963720b9c6c2e79dbff97d4c16f6b4bac4ab543 Cr-Commit-Position: refs/heads/master@{#315475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -107 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
M android_webview/android_webview_tests.gypi View 2 chunks +24 lines, -17 lines 0 comments Download
M android_webview/apk/system_webview_apk_common.gypi View 3 chunks +12 lines, -6 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +2 lines, -12 lines 0 comments Download
D android_webview/snapshot_copying.gypi View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
boliu
Created Revert of Name V8 snapshot according to target architecture (32/64 bit).
5 years, 10 months ago (2015-02-10 02:17:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868363003/1
5 years, 10 months ago (2015-02-10 02:19:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 02:19:52 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 02:21:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9963720b9c6c2e79dbff97d4c16f6b4bac4ab543
Cr-Commit-Position: refs/heads/master@{#315475}

Powered by Google App Engine
This is Rietveld 408576698