Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 868323003: Begin uniting the TabPersistentStore and StorageDelegate (Closed)

Created:
5 years, 11 months ago by gone
Modified:
5 years, 11 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Begin uniting the TabPersistentStore and StorageDelegate * Gives the two classes a common base class called TabPersister to extend. * Moves some functions for dealing with TabStates into the TabState class. * Starts combining logic for saving Tabs between the StorageDelegate and the TabPersistentStore. BUG=443773, 451280 Committed: https://crrev.com/dbd616cd21d191b02c96c19421b9ffc42a82933c Cr-Commit-Position: refs/heads/master@{#313331}

Patch Set 1 #

Patch Set 2 : whitespace #

Patch Set 3 : Ccomplaing that TabState folder can't be created only if it doesn't exist yet #

Total comments: 2

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -161 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/TabState.java View 1 2 3 2 chunks +47 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java View 1 2 18 chunks +25 lines, -75 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersister.java View 1 1 chunk +78 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/StorageDelegate.java View 6 chunks +18 lines, -51 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/RestoreMigrateTest.java View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImplTest.java View 9 chunks +14 lines, -14 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/document/OffTheRecordDocumentTabModelTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockStorageDelegate.java View 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
gone
5 years, 11 months ago (2015-01-26 21:12:37 UTC) #2
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/868323003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/TabState.java File chrome/android/java/src/org/chromium/chrome/browser/TabState.java (right): https://chromiumcodereview.appspot.com/868323003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/TabState.java#newcode329 chrome/android/java/src/org/chromium/chrome/browser/TabState.java:329: String tabStateFilename = getTabStateFilename(tabId, encrypted); Can you just ...
5 years, 11 months ago (2015-01-27 01:55:03 UTC) #3
gone
https://chromiumcodereview.appspot.com/868323003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/TabState.java File chrome/android/java/src/org/chromium/chrome/browser/TabState.java (right): https://chromiumcodereview.appspot.com/868323003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/TabState.java#newcode329 chrome/android/java/src/org/chromium/chrome/browser/TabState.java:329: String tabStateFilename = getTabStateFilename(tabId, encrypted); On 2015/01/27 01:55:03, David ...
5 years, 11 months ago (2015-01-27 19:08:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868323003/60001
5 years, 11 months ago (2015-01-27 19:09:03 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-27 19:59:54 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 20:01:01 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dbd616cd21d191b02c96c19421b9ffc42a82933c
Cr-Commit-Position: refs/heads/master@{#313331}

Powered by Google App Engine
This is Rietveld 408576698