Revert "Revert of PlzNavigate: Add a browser test for basic navigations"

Revert "Revert of PlzNavigate: Add a browser test for basic navigations"

This reverts the revert of https://chromiumcodereview.appspot.com/715203004/ by
fixing the build error.

BUG=376014, 376006, 376091
Committed: https://crrev.com/f1ccb4dd7f89c9c69f506fc1a017bf717c49c5a0
Cr-Commit-Position: refs/heads/master@{#313538}

[clamy, 2015-01-28 12:39:23]

clamy@chromium.org changed reviewers:
+ carlosk@chromium.org, nasko@chromium.org

[clamy, 2015-01-28 12:41:15]

@carlosk, nasko: PTAL

I had this CL a long time ago to add browsertests for PlzNavigate that would
(hopefully) catch regressions. I finally figured out what the issue with it on
Windows and Android was, and landed it today where it got reverted due to really
bad timing. Here is the reland for it.

[carlosk, 2015-01-28 13:49:21]

On 2015/01/28 12:41:15, clamy wrote:
> @carlosk, nasko: PTAL
> 
> I had this CL a long time ago to add browsertests for PlzNavigate that would
> (hopefully) catch regressions. I finally figured out what the issue with it on
> Windows and Android was, and landed it today where it got reverted due to
really
> bad timing. Here is the reland for it.

lgtm.

[nasko, 2015-01-28 15:21:58]

LGTM, once the comments are fixed.

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/brows...
File content/browser/browser_side_navigation_browsertest.cc (right):

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/brows...
content/browser/browser_side_navigation_browsertest.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
2014 and no (c)

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/site_...
File content/browser/site_per_process_browsertest.cc (right):

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/site_...
content/browser/site_per_process_browsertest.cc:387: // We can't use a
SitePerProcessWebContentsObserver to verify the URL here,
SitePerProcessWebContentsObserver no longer exists.

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/site_...
content/browser/site_per_process_browsertest.cc:855: // We can't use a
SitePerProcessWebContentsObserver to verify the URL here,
SitePerProcessWebContentsObserver no longer exists.

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/site_...
content/browser/site_per_process_browsertest.cc:938: // We can't use a
SitePerProcessWebContentsObserver to verify the URL here,
SitePerProcessWebContentsObserver no longer exists.

[clamy, 2015-01-28 16:24:52]

Thanks!

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/brows...
File content/browser/browser_side_navigation_browsertest.cc (right):

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/brows...
content/browser/browser_side_navigation_browsertest.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
On 2015/01/28 15:21:57, nasko (very slow until 02-02) wrote:
> 2014 and no (c)

Done.

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/site_...
File content/browser/site_per_process_browsertest.cc (right):

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/site_...
content/browser/site_per_process_browsertest.cc:387: // We can't use a
SitePerProcessWebContentsObserver to verify the URL here,
On 2015/01/28 15:21:57, nasko (very slow until 02-02) wrote:
> SitePerProcessWebContentsObserver no longer exists.

Done.

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/site_...
content/browser/site_per_process_browsertest.cc:855: // We can't use a
SitePerProcessWebContentsObserver to verify the URL here,
On 2015/01/28 15:21:57, nasko (very slow until 02-02) wrote:
> SitePerProcessWebContentsObserver no longer exists.

Done.

https://chromiumcodereview.appspot.com/868313004/diff/1/content/browser/site_...
content/browser/site_per_process_browsertest.cc:938: // We can't use a
SitePerProcessWebContentsObserver to verify the URL here,
On 2015/01/28 15:21:57, nasko (very slow until 02-02) wrote:
> SitePerProcessWebContentsObserver no longer exists.

Done.

[clamy, 2015-01-28 16:24:58]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2015-01-28 16:26:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868313004/20001

[commit-bot: I haz the power, 2015-01-28 17:41:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-28 17:42:22]

Patchset 2 (id:??) landed as
https://crrev.com/f1ccb4dd7f89c9c69f506fc1a017bf717c49c5a0
Cr-Commit-Position: refs/heads/master@{#313538}