Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1779)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 868283006: Rename MojoURLResolver to URLResolver (Closed)

Created:
5 years, 10 months ago by DaveMoore
Modified:
5 years, 10 months ago
Reviewers:
Aaron Boodman, qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rename methods for clarity #

Patch Set 3 : Rename methods for clarity #

Patch Set 4 : Rename methods for clarity #

Patch Set 5 : Garbage char #

Total comments: 2

Patch Set 6 : Remove ApplyURLMappings() call from ResolveMojoURL() #

Patch Set 7 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -210 lines) Patch
M services/window_manager/window_manager_api_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M shell/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M shell/android/mojo_main.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M shell/context.h View 3 chunks +3 lines, -3 lines 0 comments Download
M shell/context.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
D shell/mojo_url_resolver.h View 1 chunk +0 lines, -55 lines 0 comments Download
D shell/mojo_url_resolver.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D shell/mojo_url_resolver_unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M shell/shell_test_base.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M shell/shell_test_base_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M shell/shell_test_helper.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M shell/shell_test_helper.cc View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M shell/switches.cc View 1 chunk +1 line, -1 line 0 comments Download
A shell/url_resolver.h View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download
A + shell/url_resolver.cc View 1 2 3 4 5 3 chunks +25 lines, -28 lines 0 comments Download
A + shell/url_resolver_unittest.cc View 1 2 3 4 5 6 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
DaveMoore
5 years, 10 months ago (2015-02-09 21:56:25 UTC) #2
DaveMoore
Rename methods for clarity
5 years, 10 months ago (2015-02-09 23:46:55 UTC) #3
DaveMoore
Rename methods for clarity
5 years, 10 months ago (2015-02-10 00:21:37 UTC) #4
DaveMoore
Rename methods for clarity
5 years, 10 months ago (2015-02-10 00:22:41 UTC) #5
DaveMoore
Garbage char
5 years, 10 months ago (2015-02-10 00:32:20 UTC) #6
qsr
https://codereview.chromium.org/868283006/diff/80001/shell/url_resolver.h File shell/url_resolver.h (right): https://codereview.chromium.org/868283006/diff/80001/shell/url_resolver.h#newcode43 shell/url_resolver.h:43: // code for the corresponding Mojo App. This comment ...
5 years, 10 months ago (2015-02-10 09:55:20 UTC) #8
DaveMoore
Remove ApplyURLMappings() call from ResolveMojoURL()
5 years, 10 months ago (2015-02-10 17:27:30 UTC) #9
DaveMoore
https://codereview.chromium.org/868283006/diff/80001/shell/url_resolver.h File shell/url_resolver.h (right): https://codereview.chromium.org/868283006/diff/80001/shell/url_resolver.h#newcode43 shell/url_resolver.h:43: // code for the corresponding Mojo App. On 2015/02/10 ...
5 years, 10 months ago (2015-02-10 17:29:05 UTC) #10
Aaron Boodman
lgtm
5 years, 10 months ago (2015-02-10 18:53:40 UTC) #11
DaveMoore
Fix test
5 years, 10 months ago (2015-02-10 19:28:55 UTC) #13
DaveMoore
5 years, 10 months ago (2015-02-10 19:44:36 UTC) #14
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
2a897b0f0882d5dc663480e521f204759469c387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698