Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2053)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 868273003: Let the dart2dart compiler stop in case of failure. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/dart_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 19fba4a53261a32e10354a9f31356e208b16d5e8..6b15e9b2ff78fc8906d4b30fa772952680fec75b 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -278,6 +278,8 @@ abstract class Backend {
List<CompilerTask> get tasks;
+ bool get canHandleCompilationFailed;
+
void onResolutionComplete() {}
ItemCompilationContext createItemCompilationContext() {
@@ -1574,6 +1576,12 @@ abstract class Compiler implements DiagnosticListener {
api.Diagnostic.HINT);
});
}
+
+ // TODO(sigurdm): The dart backend should handle failed compilations.
+ if (compilationFailed && !backend.canHandleCompilationFailed) {
+ return;
+ }
+
if (analyzeOnly) {
if (!analyzeAll && !compilationFailed) {
// No point in reporting unused code when [analyzeAll] is true: all
« no previous file with comments | « no previous file | pkg/compiler/lib/src/dart_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698