Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 868273002: NaCl: Fix Chromium style warnings in src/trusted/plugin/ (Closed)

Created:
5 years, 11 months ago by Mark Seaborn
Modified:
5 years, 11 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Fix Chromium style warnings in src/trusted/plugin/ This fixes warnings that appear when moving this code into components/nacl/. (The Chromium style checker is disabled for code under ppapi/.) Fix warnings about "override". Fix warning about NaClSubprocess: "[chromium-style] Complex constructor has an inlined body". BUG=239656 TEST=none Committed: https://crrev.com/a202e283da0aa3a26f48af80ed2933ccae8f7289 Cr-Commit-Position: refs/heads/master@{#313091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M ppapi/native_client/src/trusted/plugin/module_ppapi.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/nacl_subprocess.h View 1 chunk +1 line, -5 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/nacl_subprocess.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
This might be a bug fix for the ~Plugin() change.
5 years, 11 months ago (2015-01-26 16:49:22 UTC) #2
teravest
lgtm
5 years, 11 months ago (2015-01-26 16:52:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868273002/1
5 years, 11 months ago (2015-01-26 17:25:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 18:00:03 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 18:00:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a202e283da0aa3a26f48af80ed2933ccae8f7289
Cr-Commit-Position: refs/heads/master@{#313091}

Powered by Google App Engine
This is Rietveld 408576698