Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sandbox/win/src/handle_inheritance_test.cc

Issue 868253011: Make chrome.exe built with ASan/Win work with sandbox enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/sandbox_win.cc ('K') | « sandbox/win/src/address_sanitizer_test.cc ('k') | sandbox/win/src/target_services.cc » ('j') | sandbox/win/src/target_services.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/handle_inheritance_test.cc
diff --git a/sandbox/win/src/handle_inheritance_test.cc b/sandbox/win/src/handle_inheritance_test.cc
index 8074c416ac3b3aec75cfa2988266aa20716a81d9..1511703dc0af9517ef6a467246ce3199890bbc3c 100644
--- a/sandbox/win/src/handle_inheritance_test.cc
+++ b/sandbox/win/src/handle_inheritance_test.cc
@@ -25,7 +25,6 @@ TEST(HandleInheritanceTests, TestStdoutInheritance) {
SECURITY_ATTRIBUTES attrs = {};
attrs.nLength = sizeof(attrs);
- attrs.lpSecurityDescriptor = NULL;
Timur Iskhodzhanov 2015/01/30 16:05:30 FYI I think this is redundant
attrs.bInheritHandle = TRUE;
HANDLE file_handle = CreateFile(
temp_file_name, GENERIC_WRITE,
« content/common/sandbox_win.cc ('K') | « sandbox/win/src/address_sanitizer_test.cc ('k') | sandbox/win/src/target_services.cc » ('j') | sandbox/win/src/target_services.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698