Make chrome.exe built with ASan/Win work with sandbox enabled

sandbox/win/src/target_services.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/win/src/target_services.h"
 
 #include <process.h>
 
 #include "base/basictypes.h"
 #include "sandbox/win/src/crosscall_client.h"
@@ skipping 56 matching lines @@
 TargetServicesBase::TargetServicesBase() {
 }
 
 ResultCode TargetServicesBase::Init() {
   process_state_.SetInitCalled();
   return SBOX_ALL_OK;
 }
 
 // Failure here is a breach of security so the process is terminated.
 void TargetServicesBase::LowerToken() {
+#if defined(ADDRESS_SANITIZER)
+  // Bind and leak dbghelp.dll before the token is lowered, otherwise
+  // AddressSanitizer will crash when trying to symbolize a report.
+  // TODO: find a better place to do this?

[rvargas (doing something else), 2015/02/02 20:55:58]

I'd say this is a type of warming so it should be done from the Chrome layer (or
where the *.pdb policy is set), even if that means code duplication for other
targets.

[Timur Iskhodzhanov, 2015/02/02 21:28:38]

Carlos, do you agree?

Btw, the *.pdb policy is set in the parent process, whilst LoadLibrary should be
called from a [almost sandboxed] child process

+  if (!LoadLibraryA("dbghelp.dll"))
+    // TODO: If this is a good place, define a new SBOX_FATAL exit code.
+    ::TerminateProcess(::GetCurrentProcess(), 0x1234);
+#endif
   if (ERROR_SUCCESS !=
       SetProcessIntegrityLevel(g_shared_delayed_integrity_level))
     ::TerminateProcess(::GetCurrentProcess(), SBOX_FATAL_INTEGRITY);
   process_state_.SetRevertedToSelf();
   // If the client code as called RegOpenKey, advapi32.dll has cached some
   // handles. The following code gets rid of them.
   if (!::RevertToSelf())
     ::TerminateProcess(::GetCurrentProcess(), SBOX_FATAL_DROPTOKEN);
   if (!FlushCachedRegHandles())
     ::TerminateProcess(::GetCurrentProcess(), SBOX_FATAL_FLUSHANDLES);
@@ skipping 98 matching lines @@
 ResultCode TargetServicesBase::DuplicateHandle(HANDLE source_handle,
                                                DWORD target_process_id,
                                                HANDLE* target_handle,
                                                DWORD desired_access,
                                                DWORD options) {
   return sandbox::DuplicateHandleProxy(source_handle, target_process_id,
                                        target_handle, desired_access, options);
 }
 
 }  // namespace sandbox