Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 868253004: Fix variable shadowing warning in registry on VS2015 (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-json_parser
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix variable shadowing warning in registry on VS2015 d:\src\cr3\src\base\win\registry.cc(665): error C2220: warning treated as error - no 'object' file generated d:\src\cr3\src\base\win\registry.cc(665): warning C4456: declaration of 'result' hides previous local declaration d:\src\cr3\src\base\win\registry.cc(659): note: see declaration of 'result' I don't think there's any need for separate variables. R=cpu@chromium.org BUG=440500 Committed: https://crrev.com/91e3049633eebd097f548c20aabf94aac6e8907a Cr-Commit-Position: refs/heads/master@{#313373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/win/registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
scottmg
5 years, 11 months ago (2015-01-27 19:31:00 UTC) #1
Will Harris
lgtm
5 years, 11 months ago (2015-01-27 19:32:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868253004/1
5 years, 11 months ago (2015-01-27 20:14:41 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38674) Try jobs failed on following ...
5 years, 11 months ago (2015-01-27 20:21:26 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm
5 years, 11 months ago (2015-01-27 20:27:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868253004/1
5 years, 11 months ago (2015-01-27 20:28:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38674)
5 years, 11 months ago (2015-01-27 20:28:36 UTC) #11
scottmg
Will was just taunting me apparently!
5 years, 11 months ago (2015-01-27 20:28:55 UTC) #12
Will Harris
:)
5 years, 11 months ago (2015-01-27 20:50:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868253004/1
5 years, 11 months ago (2015-01-27 22:10:53 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 22:12:06 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 22:14:19 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91e3049633eebd097f548c20aabf94aac6e8907a
Cr-Commit-Position: refs/heads/master@{#313373}

Powered by Google App Engine
This is Rietveld 408576698