Small clean up in PlatformKeysService.

Small clean up in PlatformKeysService.

This changes the internal function GetPlatformKeysOfExtension to always pass a PlatformKeys value to its callback.
The only function change is: If the base::Value read from StateStore has an incorrect type, it will be ignored and a new empty (but correct) value will be created.

BUG=450167
Committed: https://crrev.com/413d67aed95f4b6371ac8574815e670aca17c19d
Cr-Commit-Position: refs/heads/master@{#314348}

[pneubeck (no reviews), 2015-02-02 10:00:07]

Patchset #1 (id:1) has been deleted

[pneubeck (no reviews), 2015-02-02 10:03:57]

pneubeck@chromium.org changed reviewers:
+ bartfab@chromium.org

[pneubeck (no reviews), 2015-02-02 10:03:58]

ptal at this one first.

[pneubeck (no reviews), 2015-02-02 12:39:11]

pneubeck@chromium.org changed reviewers:
+ tnagel@chromium.org
- bartfab@chromium.org

[pneubeck (no reviews), 2015-02-02 12:39:11]

-Bartosz, +Thiemo

[Thiemo Nagel, 2015-02-03 10:35:46]

Please give a proper description of what this CL does and mention whether (and
if how) it is supposed to change the behaviour of the code.

https://codereview.chromium.org/868243004/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/platform_keys/platform_keys_service.cc (right):

https://codereview.chromium.org/868243004/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/platform_keys/platform_keys_service.cc:33: //
|public_key_spki_der| if |true| is passed to it.
Please update the comment.

[pneubeck (no reviews), 2015-02-03 10:54:52]

thx for taking a look.

https://codereview.chromium.org/868243004/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/platform_keys/platform_keys_service.cc (right):

https://codereview.chromium.org/868243004/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/platform_keys/platform_keys_service.cc:33: //
|public_key_spki_der| if |true| is passed to it.
On 2015/02/03 10:35:46, Thiemo Nagel wrote:
> Please update the comment.

you passed the test :-)

[Thiemo Nagel, 2015-02-03 13:34:17]

https://codereview.chromium.org/868243004/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/platform_keys/platform_keys_service.cc (right):

https://codereview.chromium.org/868243004/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/platform_keys/platform_keys_service.cc:32: void
RunGenerateKeyCallbackWithResult(
s/WithResult// ?

[pneubeck (no reviews), 2015-02-03 15:33:44]

https://codereview.chromium.org/868243004/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/platform_keys/platform_keys_service.cc (right):

https://codereview.chromium.org/868243004/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/platform_keys/platform_keys_service.cc:32: void
RunGenerateKeyCallbackWithResult(
On 2015/02/03 13:34:17, Thiemo Nagel wrote:
> s/WithResult// ?

Done.

[Thiemo Nagel, 2015-02-03 15:57:19]

lgtm

[pneubeck (no reviews), 2015-02-03 15:58:27]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2015-02-03 15:59:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868243004/60001

[commit-bot: I haz the power, 2015-02-03 16:30:37]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-02-03 16:32:30]

Patchset 3 (id:??) landed as
https://crrev.com/413d67aed95f4b6371ac8574815e670aca17c19d
Cr-Commit-Position: refs/heads/master@{#314348}