Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 868243003: Define SK_OVERRIDE when building for Android framework. (Closed)

Created:
5 years, 10 months ago by scroggo
Modified:
5 years, 10 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Define SK_OVERRIDE when building for Android framework. Committed: https://skia.googlesource.com/skia/+/803a49dfcf88c47e3b1824f583cb65269ed3a01b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scroggo
Alternatively, we could define it anytime we're building for Android, if the NDK is ready ...
5 years, 10 months ago (2015-01-30 14:11:33 UTC) #2
djsollen
lgtm
5 years, 10 months ago (2015-01-30 14:12:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868243003/1
5 years, 10 months ago (2015-01-30 14:13:58 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 14:19:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/803a49dfcf88c47e3b1824f583cb65269ed3a01b

Powered by Google App Engine
This is Rietveld 408576698