Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
868233008:
Build in C++11 mode on Unix-like bots. (Closed)
DescriptionBuild in C++11 mode on Unix-like bots.
Mac and Windows bots are already building in C++11 mode.
This turns on the rest, mostly to see what work remains.
This will probably break a few bots. It'd be nice if we could let those
all come in as red before reverting this so I can see the full list to fix.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/779e49602a9c8f4d2799504822e01bcafbcaa534
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu13.10-GCC4.8-NaCl-Release-Trybot,Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot
Committed: https://skia.googlesource.com/skia/+/f3cdce79103558c4136cc6e8b04d50a0b0f04eb4
Patch Set 1 #Patch Set 2 : gyp #Patch Set 3 : revert dm #Patch Set 4 : put back #
Total comments: 1
Patch Set 5 : updated #Patch Set 6 : updated #Patch Set 7 : ios too? #Patch Set 8 : nacl #Messages
Total messages: 31 (12 generated)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868233008/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-04 20:00 UTC
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868233008/20001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-04 20:03 UTC
The CQ bit was unchecked by mtklein@google.com
mtklein@chromium.org changed reviewers: + stephana@google.com - mtklein@google.com
https://codereview.chromium.org/868233008/diff/60001/gyp/common_conditions.gypi File gyp/common_conditions.gypi (left): https://codereview.chromium.org/868233008/diff/60001/gyp/common_conditions.gy... gyp/common_conditions.gypi:219: '-Wno-c++11-extensions', Not meaningful when using -std=c++11.
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868233008/60001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-04 20:15 UTC
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868233008/60001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-04 20:21 UTC
On 2015/02/04 14:21:04, I haz the power (commit-bot) wrote: > Note for Reviewers: > The CQ is waiting for an approval. > If you believe that the CL is not ready yet, or if you would like to L-G-T-M > with comments then please uncheck the CQ checkbox. > > Waiting for LGTM from valid reviewer(s) till 2015-02-04 20:21 UTC I'll L G T M this as soon as the bots are back to green so start from a clean baseline.
On 2015/02/04 14:32:24, stephana wrote: > On 2015/02/04 14:21:04, I haz the power (commit-bot) wrote: > > Note for Reviewers: > > The CQ is waiting for an approval. > > If you believe that the CL is not ready yet, or if you would like to L-G-T-M > > with comments then please uncheck the CQ checkbox. > > > > Waiting for LGTM from valid reviewer(s) till 2015-02-04 20:21 UTC > > I'll L G T M this as soon as the bots are back to green so start from a clean > baseline. lgtm
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/779e49602a9c8f4d2799504822e01bcafbcaa534
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/879803003/ by mtklein@google.com. The reason for reverting is: Perf-Ubuntu12, and Test-Ubuntu12, Build-Nacl all too old. Android and Chrome OS builders look ok. Android testers look ok. Chrome OS testers haven't run yet..
> Android testers look ok. Chrome OS testers haven't run yet.. Chrome OS testers look ok too.
New patchsets have been uploaded after l-g-t-m from stephana@google.com
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868233008/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-NaCl-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868233008/140001
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://skia.googlesource.com/skia/+/f3cdce79103558c4136cc6e8b04d50a0b0f04eb4 |
