Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: public/web/WebServiceWorkerContextClient.h

Issue 868233006: [ServiceWorker] Cleanup to remove old focus() code kept to not break Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_client
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « public/platform/WebServiceWorkerClientFocusCallback.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef WebServiceWorkerContextClient_h 31 #ifndef WebServiceWorkerContextClient_h
32 #define WebServiceWorkerContextClient_h 32 #define WebServiceWorkerContextClient_h
33 33
34 #include "WebWorkerPermissionClientProxy.h" 34 #include "WebWorkerPermissionClientProxy.h"
35 #include "public/platform/WebMessagePortChannel.h" 35 #include "public/platform/WebMessagePortChannel.h"
36 #include "public/platform/WebServiceWorkerClientFocusCallback.h"
37 #include "public/platform/WebServiceWorkerClientsClaimCallbacks.h" 36 #include "public/platform/WebServiceWorkerClientsClaimCallbacks.h"
38 #include "public/platform/WebServiceWorkerClientsInfo.h" 37 #include "public/platform/WebServiceWorkerClientsInfo.h"
39 #include "public/platform/WebServiceWorkerEventResult.h" 38 #include "public/platform/WebServiceWorkerEventResult.h"
40 #include "public/platform/WebServiceWorkerSkipWaitingCallbacks.h" 39 #include "public/platform/WebServiceWorkerSkipWaitingCallbacks.h"
41 #include "public/platform/WebURL.h" 40 #include "public/platform/WebURL.h"
42 41
43 namespace blink { 42 namespace blink {
44 43
45 struct WebCrossOriginServiceWorkerClient; 44 struct WebCrossOriginServiceWorkerClient;
46 class WebDataSource; 45 class WebDataSource;
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 // Ownership of the passed callbacks is transferred to the callee, callee 164 // Ownership of the passed callbacks is transferred to the callee, callee
166 // should delete the callbacks after run. 165 // should delete the callbacks after run.
167 virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) { BLINK_ASSE RT_NOT_REACHED(); } 166 virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) { BLINK_ASSE RT_NOT_REACHED(); }
168 167
169 // Ownership of the passed callbacks is transferred to the callee, callee 168 // Ownership of the passed callbacks is transferred to the callee, callee
170 // should delete the callbacks after run. 169 // should delete the callbacks after run.
171 virtual void claim(WebServiceWorkerClientsClaimCallbacks*) { BLINK_ASSERT_NO T_REACHED(); } 170 virtual void claim(WebServiceWorkerClientsClaimCallbacks*) { BLINK_ASSERT_NO T_REACHED(); }
172 171
173 // Ownership of the passed callbacks is transferred to the callee, callee 172 // Ownership of the passed callbacks is transferred to the callee, callee
174 // should delete the callback after calling either onSuccess or onError. 173 // should delete the callback after calling either onSuccess or onError.
175 // FIXME: delete this method as soon as Chromium stop calling it.
176 virtual void focus(int clientID, WebServiceWorkerClientFocusCallback*) { BLI NK_ASSERT_NOT_REACHED(); }
177
178 // Ownership of the passed callbacks is transferred to the callee, callee
dominicc (has gone to gerrit) 2015/02/02 18:25:36 Why not keep the comment about ownership?
mlamouri (slow - plz ping) 2015/02/06 14:05:47 The comment is still, it's just a bit above. The d
179 // should delete the callback after calling either onSuccess or onError.
180 virtual void focus(int cliendID, WebServiceWorkerClientCallbacks*) { BLINK_A SSERT_NOT_REACHED(); } 174 virtual void focus(int cliendID, WebServiceWorkerClientCallbacks*) { BLINK_A SSERT_NOT_REACHED(); }
181 }; 175 };
182 176
183 } // namespace blink 177 } // namespace blink
184 178
185 #endif // WebServiceWorkerContextClient_h 179 #endif // WebServiceWorkerContextClient_h
OLDNEW
« no previous file with comments | « public/platform/WebServiceWorkerClientFocusCallback.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698