Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 868213002: [PATCH 7/11] ozone: evdev: Move GesturePropertyProvider to InputDeviceFactoryEvdev (Closed)

Created:
5 years, 11 months ago by spang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Move GesturePropertyProvider to InputDeviceFactoryEvdev This is part of a series moving IO on evdev devices to a fast thread, since UI thread is too slow for the cursor. This properties object owns memory accessed by libgestures, and so needs to be be on the same thread as any gestures devices. So move it from EventFactoryEvdev into InputDeviceFactoryEvdev. BUG=449710 TEST=boot link_freon & move mouse Committed: https://crrev.com/cb5b28b7b29d233141634fb619f743d241b63dcc Cr-Commit-Position: refs/heads/master@{#313860}

Patch Set 1 #

Patch Set 2 : updates for events_unittests #

Total comments: 1

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -229 lines) Patch
M ui/events/ozone/evdev/event_factory_evdev.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 3 3 chunks +3 lines, -20 lines 0 comments Download
M ui/events/ozone/evdev/input_controller_evdev.h View 1 2 3 4 chunks +1 line, -24 lines 0 comments Download
M ui/events/ozone/evdev/input_controller_evdev.cc View 1 2 3 4 chunks +23 lines, -171 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.h View 1 2 3 4 chunks +22 lines, -4 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.cc View 1 2 3 6 chunks +171 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
spang
5 years, 11 months ago (2015-01-23 21:59:31 UTC) #2
spang
5 years, 11 months ago (2015-01-27 19:34:13 UTC) #3
alexst (slow to review)
https://codereview.chromium.org/868213002/diff/20001/ui/events/ozone/evdev/input_device_factory_evdev.cc File ui/events/ozone/evdev/input_device_factory_evdev.cc (left): https://codereview.chromium.org/868213002/diff/20001/ui/events/ozone/evdev/input_device_factory_evdev.cc#oldcode163 ui/events/ozone/evdev/input_device_factory_evdev.cc:163: GesturePropertyProvider* gesture_property_provider, So this is never used and created ...
5 years, 11 months ago (2015-01-27 20:25:28 UTC) #4
alexst (slow to review)
lgtm pending the fix from [6/11]
5 years, 10 months ago (2015-01-28 13:29:15 UTC) #5
spang
On 2015/01/28 13:29:15, alexst wrote: > lgtm pending the fix from [6/11] Done.
5 years, 10 months ago (2015-01-28 19:03:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868213002/60001
5 years, 10 months ago (2015-01-30 01:44:14 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-30 02:21:42 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 02:23:31 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cb5b28b7b29d233141634fb619f743d241b63dcc
Cr-Commit-Position: refs/heads/master@{#313860}

Powered by Google App Engine
This is Rietveld 408576698