Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: chrome/browser/captive_portal/captive_portal_browsertest.cc

Issue 868203004: Disable CaptivePortalBrowserTest.InterstitialTimerNavigateAwayWhileLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/captive_portal/captive_portal_browsertest.cc
diff --git a/chrome/browser/captive_portal/captive_portal_browsertest.cc b/chrome/browser/captive_portal/captive_portal_browsertest.cc
index 7fd838939b3079a964889e8fcfb606b7defcd5d0..ad2345c06cc47516b09a939425e4236593693f47 100644
--- a/chrome/browser/captive_portal/captive_portal_browsertest.cc
+++ b/chrome/browser/captive_portal/captive_portal_browsertest.cc
@@ -2126,10 +2126,20 @@ IN_PROC_BROWSER_TEST_F(CaptivePortalBrowserTest,
GetStateOfTabReloaderAt(browser(), 0));
}
+// This test is very flaky on Linux and is disabled.
+// https://crbug.com/453875
+#if defined(OS_LINUX)
+#define MAYBE_InterstitialTimerNavigateAwayWhileLoading \
+ DISABLED_InterstitialTimerNavigateAwayWhileLoading
+#else
+#define MAYBE_InterstitialTimerNavigateAwayWhileLoading \
+ InterstitialTimerNavigateAwayWhileLoading
+#endif
+
// Same as above, but instead of reloading, the page is navigated away. The new
// page should load, and no interstitials should be shown.
IN_PROC_BROWSER_TEST_F(CaptivePortalBrowserTest,
- InterstitialTimerNavigateAwayWhileLoading) {
+ MAYBE_InterstitialTimerNavigateAwayWhileLoading) {
net::SpawnedTestServer::SSLOptions https_options;
https_options.server_certificate =
net::SpawnedTestServer::SSLOptions::CERT_MISMATCHED_NAME;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698