remoting/webapp/crd/js/desktop_remoting.js - Issue 868203002: Handle authentication failures in the v2 app by restarting the app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/desktop_remoting.js

Issue 868203002: Handle authentication failures in the v2 app by restarting the app (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer's feedback Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/webapp/base/js/auth_dialog.js ('K') | « remoting/webapp/crd/js/crd_event_handlers.js ('k') | remoting/webapp/crd/js/host_list.js » ('j') | remoting/webapp/crd/js/identity.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/webapp/crd/js/desktop_remoting.js

diff --git a/remoting/webapp/crd/js/desktop_remoting.js b/remoting/webapp/crd/js/desktop_remoting.js

index ad9f0b652680ffc44988614ca2432176e5569e2c..9fd22111dcd24bc631364c977e166cc24bff4f03 100644

--- a/remoting/webapp/crd/js/desktop_remoting.js

+++ b/remoting/webapp/crd/js/desktop_remoting.js

@@ -278,6 +278,12 @@ remoting.DesktopRemoting.prototype.handleError = function(errorTag) {

console.error('Connection failed: ' + errorTag);

remoting.accessCode = '';

+ if (errorTag === remoting.Error.AUTHENTICATION_FAILED) {

+ remoting.setMode(remoting.AppMode.HOME);

+ remoting.identity.handleAuthFailureAndRelaunch();

+ return;

+ }

// Reset the refresh flag so that the next connection will retry if needed.

this.refreshHostJidIfOffline_ = true;

« remoting/webapp/base/js/auth_dialog.js ('K') | « remoting/webapp/crd/js/crd_event_handlers.js ('k') | remoting/webapp/crd/js/host_list.js » ('j') | remoting/webapp/crd/js/identity.js » ('J')