Handle authentication failures in the v2 app by restarting the app

remoting/webapp/crd/js/desktop_remoting.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * This class implements the functionality that is specific to desktop
  * remoting ("Chromoting" or CRD).
  */
 
@@ skipping 261 matching lines @@
 /**
  * Called when an error needs to be displayed to the user.
  *
  * @param {remoting.Error} errorTag The error to be localized and displayed.
  * @return {void} Nothing.
  */
 remoting.DesktopRemoting.prototype.handleError = function(errorTag) {
   console.error('Connection failed: ' + errorTag);
   remoting.accessCode = '';
 
+  if (errorTag === remoting.Error.AUTHENTICATION_FAILED) {
+    remoting.setMode(remoting.AppMode.HOME);

[Jamie, 2015/01/23 23:33:26]

We should still show an error in this case. Would it be substantially more
complex to do that? I don't want to waste a lot of time polishing this UX, but
relaunching without telling the user you're going to do so is jarring

[kelvinp, 2015/01/28 00:26:45]

Ya, it would be some work to show the error cleanly, as the reconnect dialog is
hardcoded to reconnect (which doesn't fix any auth problem).  As discussed, I
think this would be a very rare scenario.  I would prefer to leave the code as
it is.

+    remoting.identity.handleAuthFailureAndRelaunch();
+    return;
+  }
+
   // Reset the refresh flag so that the next connection will retry if needed.
   this.refreshHostJidIfOffline_ = true;
 
   var errorDiv = document.getElementById('connect-error-message');
   l10n.localizeElementFromTag(errorDiv, /** @type {string} */ (errorTag));
 
   var mode = remoting.clientSession ? remoting.clientSession.getMode()
       : this.app_.getSessionConnector().getConnectionMode();
   if (mode == remoting.ClientSession.Mode.IT2ME) {
     remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_IT2ME);
     remoting.hangoutSessionEvents.raiseEvent(
         remoting.hangoutSessionEvents.sessionStateChanged,
         remoting.ClientSession.State.FAILED
     );
   } else {
     remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_ME2ME);
   }
 };